[ovs-discuss] About controller rate limiting statistics

[Ben Pfaff]

I think you're right.  Can you provide a Signed-off-by, to indicate that
you agree to including the patch?  Please see CONTRIBUTING.rst for full
information.

Thanks,

Ben.

On Sat, Dec 03, 2016 at 11:46:35PM +0000, Ken Ajiro wrote:
> 
>   Hello,
> 
>   When I used controller packet-in rate limiting (controller_rate_limit in
>   controller table), I found that incorrect statistics was increased.
> 
>   I think that following fix is needed.
> 
>   Thanks,
> 
> -- 
> Ken Ajiro
> 
> 
> diff --git a/ofproto/connmgr.c b/ofproto/connmgr.c
> index 4b927d6..bfd1ff5 100644
> --- a/ofproto/connmgr.c
> +++ b/ofproto/connmgr.c
> @@ -539,7 +539,7 @@ connmgr_get_controller_info(struct connmgr *mgr, struct shash *info)
> 
>              for (i = 0; i < N_SCHEDULERS; i++) {
>                  if (ofconn->schedulers[i]) {
> -                    const char *name = i ? "miss" : "action";
> +                    const char *name = i == 0 ? "miss" : "action";
>                      struct pinsched_stats stats;
> 
>                      pinsched_get_stats(ofconn->schedulers[i], &stats);
> _______________________________________________
> discuss mailing list
> discuss at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-discuss