[ovs-discuss] ofport->may_enable flag in run_port()

Zoltán Balogh zoltan.balogh at ericsson.com
Fri Feb 5 11:47:05 UTC 2016


Hi,

The ofport->may_enable flag is set in the run_port() function of ofproto-dpif.
I was looking at this code below:

    if (ofport->bundle) {
        enable = enable && lacp_slave_may_enable(ofport->bundle->lacp, ofport);
        if (carrier_changed) {
            lacp_slave_carrier_changed(ofport->bundle->lacp, ofport);
        }
    }

The lacp_slave_may_enable() function may return true even if ofport->bundle->lacp is NULL.
So if the port is up and lacp is not set then ofport->may_enable could be set to true. Is this correct?

Best regards,
Zoltán



More information about the discuss mailing list