[ovs-discuss] ofport->may_enable flag in run_port()

Ben Pfaff blp at ovn.org
Fri Feb 5 18:18:19 UTC 2016


On Fri, Feb 05, 2016 at 11:47:05AM +0000, Zoltán Balogh wrote:
> Hi,
> 
> The ofport->may_enable flag is set in the run_port() function of ofproto-dpif.
> I was looking at this code below:
> 
>     if (ofport->bundle) {
>         enable = enable && lacp_slave_may_enable(ofport->bundle->lacp, ofport);
>         if (carrier_changed) {
>             lacp_slave_carrier_changed(ofport->bundle->lacp, ofport);
>         }
>     }
> 
> The lacp_slave_may_enable() function may return true even if ofport->bundle->lacp is NULL.
> So if the port is up and lacp is not set then ofport->may_enable could be set to true. Is this correct?

Yes.  If LACP is not running then there's no reason for it to disable
ports.



More information about the discuss mailing list