[ovs-discuss] Bug in error logging

Ben Pfaff blp at ovn.org
Wed Jun 1 04:54:18 UTC 2016


On Sun, May 29, 2016 at 01:00:28PM +0200, Josh Hershberg wrote:
> In the file lib/dpif-netlink.c in the function dpif_netlink_init the value
> of error is not initialized. 

It's static, so it's initialized to zero at program start.

> If ovsthread_once_start return false, a random error code is
> returned. This occurred in my setup when running "ovs-vsctl add-br
> br1". Here's the stack trace: #0 ofproto_tunnel_init () at
> ofproto/tunnel.c:138 #1 0x0000556adf5a417d in construct
> (ofproto_=0x556ae07bd960) at ofproto/ofproto-dpif.c:1306 #2
> 0x0000556adf591f6c in ofproto_create (datapath_name=0x556ae07b6a80
> "br1", datapath_type=<optimized out>,
> ofprotop=ofprotop at entry=0x556ae07e08a8) at ofproto/ofproto.c:578 #3
> 0x0000556adf583d33 in bridge_reconfigure
> (ovs_cfg=ovs_cfg at entry=0x556ae07e1450) at vswitchd/bridge.c:633 #4
> 0x0000556adf5851cf in bridge_run () at vswitchd/bridge.c:2975 #5
> 0x0000556adf57b5f5 in main (argc=2, argv=0x7ffc9c326ad8) at
> vswitchd/ovs-vswitchd.c:120
> 
> and the error reported was (errno 2) when in reality it's the fact that the
> lock fails:
> 2016-05-29T11:50:33Z|00770|ofproto|ERR|failed to open datapath br1: No such
> file or directory
> 2016-05-29T11:50:33Z|00771|bridge|ERR|failed to create bridge br1: No such
> file or directory

What lock?

Thanks,

Ben.


More information about the discuss mailing list