[ovs-discuss] Error in "Make" after patching OVS

Mark Michelson mmichels at redhat.com
Tue Apr 3 13:28:51 UTC 2018


This is because you altered an enum, which resulted in the 
OVS_KEY_ATTR_TUNNEL_INFO value changing. You need to adjust the 
BUILD_BUG_ON statement referenced in the error message to compare to the 
new value instead.

I don't mean to be rude, but the questions you have been asking on this 
list have been pretty basic. I feel like you could have figured out the 
answers by doing some local debugging or using your search engine of 
choice. I recommend that you take more time to try to learn the answers 
on your own before mailing the list next time. You'll learn more by 
doing it that way.

On 04/03/2018 12:23 AM, Taimur Hafeez wrote:
> thanks dear! I did changing and here is the result of new compilation:
> taimur at ubuntuibm:~/Music/openvswitch-2.6.0$ make
> sed -f ./build-aux/extract-odp-netlink-h < 
> datapath/linux/compat/include/linux/openvswitch.h > include/odp-netlink.h
> make  all-recursive
> make[1]: Entering directory `/home/taimur/Music/openvswitch-2.6.0'
> Making all in datapath
> make[2]: Entering directory `/home/taimur/Music/openvswitch-2.6.0/datapath'
> Making all in linux
> make[3]: Entering directory 
> `/home/taimur/Music/openvswitch-2.6.0/datapath/linux'
> make -C /lib/modules/4.4.0-31-generic/build 
> M=/home/taimur/Music/openvswitch-2.6.0/datapath/linux modules
> make[4]: Entering directory `/usr/src/linux-headers-4.4.0-31-generic'
>    CC [M]  /home/taimur/Music/openvswitch-2.6.0/datapath/linux/actions.o
>    CC [M]  /home/taimur/Music/openvswitch-2.6.0/datapath/linux/conntrack.o
>    CC [M]  /home/taimur/Music/openvswitch-2.6.0/datapath/linux/datapath.o
>    CC [M]  /home/taimur/Music/openvswitch-2.6.0/datapath/linux/dp_notify.o
>    CC [M]  /home/taimur/Music/openvswitch-2.6.0/datapath/linux/flow.o
>    CC [M]  
> /home/taimur/Music/openvswitch-2.6.0/datapath/linux/flow_netlink.o
> In file included from 
> /home/taimur/Music/openvswitch-2.6.0/datapath/linux/compat/include/linux/compiler.h:4:0,
>                   from include/uapi/linux/stddef.h:1,
>                   from include/linux/stddef.h:4,
>                   from 
> /home/taimur/Music/openvswitch-2.6.0/datapath/linux/compat/include/linux/stddef.h:4,
>                   from ./include/uapi/linux/posix_types.h:4,
>                   from include/uapi/linux/types.h:13,
>                   from include/linux/types.h:5,
>                   from 
> /home/taimur/Music/openvswitch-2.6.0/datapath/linux/compat/include/linux/types.h:4,
>                   from include/uapi/linux/capability.h:16,
>                   from include/linux/capability.h:15,
>                   from include/linux/sched.h:15,
>                   from include/linux/uaccess.h:4,
>                   from 
> /home/taimur/Music/openvswitch-2.6.0/datapath/linux/flow_netlink.c:21:
> /home/taimur/Music/openvswitch-2.6.0/datapath/linux/flow_netlink.c: In 
> function ‘ovs_key_attr_size’:
> include/linux/compiler.h:467:20: error: call to 
> ‘__compiletime_assert_287’ declared with attribute error: BUILD_BUG_ON 
> failed: OVS_KEY_ATTR_TUNNEL_INFO != 26
>      prefix ## suffix();    \
>                      ^
> include/linux/compiler.h:472:2: note: in expansion of macro 
> ‘__compiletime_assert’
>    __compiletime_assert(condition, msg, prefix, suffix)
>    ^
> include/linux/compiler.h:484:2: note: in expansion of macro 
> ‘_compiletime_assert’
>    _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
>    ^
> include/linux/bug.h:50:37: note: in expansion of macro ‘compiletime_assert’
>   #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>                                       ^
> include/linux/bug.h:74:2: note: in expansion of macro ‘BUILD_BUG_ON_MSG’
>    BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
>    ^
> /home/taimur/Music/openvswitch-2.6.0/datapath/linux/flow_netlink.c:287:2: note: 
> in expansion of macro ‘BUILD_BUG_ON’
>    BUILD_BUG_ON(OVS_KEY_ATTR_TUNNEL_INFO != 26);
>    ^
> make[5]: *** 
> [/home/taimur/Music/openvswitch-2.6.0/datapath/linux/flow_netlink.o] Error 1
> make[4]: *** 
> [_module_/home/taimur/Music/openvswitch-2.6.0/datapath/linux] Error 2
> make[4]: Leaving directory `/usr/src/linux-headers-4.4.0-31-generic'
> make[3]: *** [default] Error 2
> make[3]: Leaving directory 
> `/home/taimur/Music/openvswitch-2.6.0/datapath/linux'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory `/home/taimur/Music/openvswitch-2.6.0/datapath'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/home/taimur/Music/openvswitch-2.6.0'
> make: *** [all] Error 2
> 
> 
> On Mon, Apr 2, 2018 at 7:21 PM, Mark Michelson <mmichels at redhat.com 
> <mailto:mmichels at redhat.com>> wrote:
> 
>     ovs_be16 is defined in a userspace header file and shouldn't be used
>     in the Linux datapath code. You probably should be using __be16 instead.
> 
> 
>     On 04/02/2018 01:46 AM, Taimur Hafeez wrote:
> 
>         Dear all,
>         I patched OVS successfully but when I issue "make" command it
>         gives following error:
> 
> 
>         taimur at ubuntuibm:~/openvswitch-2.6.0$ make
>         make  all-recursive
>         make[1]: Entering directory `/home/taimur/openvswitch-2.6.0'
>         Making all in datapath
>         make[2]: Entering directory
>         `/home/taimur/openvswitch-2.6.0/datapath'
>         Making all in linux
>         make[3]: Entering directory
>         `/home/taimur/openvswitch-2.6.0/datapath/linux'
>         make -C /lib/modules/4.4.0-31-generic/build
>         M=/home/taimur/openvswitch-2.6.0/datapath/linux modules
>         make[4]: Entering directory
>         `/usr/src/linux-headers-4.4.0-31-generic'
>             CC [M]  /home/taimur/openvswitch-2.6.0/datapath/linux/actions.o
>         In file included from
>         /home/taimur/openvswitch-2.6.0/datapath/linux/actions.c:24:0:
>         /home/taimur/openvswitch-2.6.0/datapath/linux/compat/include/linux/openvswitch.h:443:2:
>         error: unknown type name ‘ovs_be16’
>             ovs_be16 rwnd;
>             ^
>         make[5]: ***
>         [/home/taimur/openvswitch-2.6.0/datapath/linux/actions.o] Error 1
>         make[4]: ***
>         [_module_/home/taimur/openvswitch-2.6.0/datapath/linux] Error 2
>         make[4]: Leaving directory `/usr/src/linux-headers-4.4.0-31-generic'
>         make[3]: *** [default] Error 2
>         make[3]: Leaving directory
>         `/home/taimur/openvswitch-2.6.0/datapath/linux'
>         make[2]: *** [all-recursive] Error 1
>         make[2]: Leaving directory `/home/taimur/openvswitch-2.6.0/datapath'
>         make[1]: *** [all-recursive] Error 1
>         make[1]: Leaving directory `/home/taimur/openvswitch-2.6.0'
>         make: *** [all] Error 2
> 
>         Could any body help on this? Thanks!
> 
> 
>         Best regards,
>         --------------------
>         Taimur Hafeez
> 
> 
> 
>         _______________________________________________
>         discuss mailing list
>         discuss at openvswitch.org <mailto:discuss at openvswitch.org>
>         https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
>         <https://mail.openvswitch.org/mailman/listinfo/ovs-discuss>
> 
> 
> 
> 
> 
> -- 
> 
> 
> Best regards,
> --------------------
> Taimur Hafeez
> *NUST* *S*chool of *E*lectrical *E*ngineering and *C*omputer *S*cience 
> *(SEECS)*,Islamabad, Pakistan.
> Linkedin <https://www.linkedin.com/in/taimurhafeez>
> Mobile:_+923367991993
> _



More information about the discuss mailing list