[ovs-discuss] Reg. ofproto: ofproto_rule_insert__

[Vishal Deep Ajmera]

Hi,

In bundle based resync, we try to apply all rules from the bundle one-by-one. If a rule encounters any error, we revert back (undo) rules which were applied successfully. This is accomplished in function add_flow_revert() -> replace_rule_revert() -> ofproto_rule_insert__() using old_rule pointer. The old_rule state in this case would be RULE_REMOVED since the rule has been successfully replaced by new_rule. However, function ofproto_rule_insert__() is asserting when rule->state != RULE_INITIALIZED. Is this correct ? I think assert condition should be: ovs_assert(rule->state != RULE_INSERTED).

Does this make sense ? I am not very familiar with bundle based resync's though. If the change looks ok, I will post a patch in dev-list.

Warm Regards,
Vishal Ajmera

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-discuss/attachments/20180612/28bdcc06/attachment.html>