[ovs-discuss] OvS using newer DPDK

[Ilya Maximets]

On 08.11.2018 16:46, Ophir Munk wrote:
> Thank you for your comments. Please see inline.
> 
>> -----Original Message-----
>> From: Ilya Maximets [mailto:i.maximets at samsung.com]
>> Sent: Thursday, November 01, 2018 10:31 AM
>> To: Ophir Munk <ophirmu at mellanox.com>; Stokes, Ian
>> <ian.stokes at intel.com>; Andrzej Ostruszka <amo at semihalf.com>; ovs-
>> discuss at openvswitch.org; ovs-dev at openvswitch.org
>> Cc: tiago.lam at intel.com; Eelco Chaudron <echaudro at redhat.com>; Kevin
>> Traynor <ktraynor at redhat.com>; Olga Shern <olgas at mellanox.com>;
>> Shahaf Shuler <shahafs at mellanox.com>; Ben Pfaff <blp at ovn.org>
>> Subject: Re: [ovs-discuss] OvS using newer DPDK
>>
>> On 31.10.2018 19:16, Ophir Munk wrote:
>>> Guys,
>>> Any comments to OVS upgrade to dpdk 18.08?
>>>
>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat
>>>
>> chwork.ozlabs.org%2Fproject%2Fopenvswitch%2Flist%2F%3Fseries%3D7260
>> 6&a
>>>
>> mp;data=02%7C01%7Cophirmu%40mellanox.com%7C272bf1f6bfc44562239
>> 708d63fd
>>>
>> 4558e%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636766578
>> 544164280&
>>>
>> amp;sdata=OM6GiLKvibDDRcK4AsKwhUbSGEPRqUcldTvpdJ4AXzE%3D&amp;
>> reserved=
>>> 0
>>
>> I don't see them on a list. I guess, they was sent while the list was down.
>>
>> Few commnets:
>> 1. Until your patch for RSS key len is not merged in DPDK, we have to
>>    provide some rss_key. Otherwise offloading will not work for mlx NICs.
>>    Do you expect that patch will be in 18.11 release? The window is closed
>>    for the new features already.
> 
> Yes, the patch is already in 18.11 release. There is no need to provide rss_key. 
> Anyway, it's impossible to supply one key that would fit all NICS.
> 
>>
>> 2. IMHO, it's better to return the action_rss_data structure itself and
>>    use just a field instead of freeing with container_of and writing a
>>    huge comment.
>>
> 
> I am in favor of returning the rss field rather than the action_rss_data structure.

This makes no sense for me. We're returning 'rss' just to free it later.
There is no other operations on that variable. Why not return 'action_rss_data'
to free it? Why we need all these complications?

Another solution could be to just completely inline 'add_flow_rss_action'
function. We're not using it anywhere else.

> The huge comment was added in response to another review request. I can reduce it in a follow up commit.
> 
>> Best regards, Ilya Maximets.
>>
>>>
>>> Regards,
>>> Ophir
>>>
>>>> -----Original Message-----
>>>> From: Stokes, Ian [mailto:ian.stokes at intel.com]
>>>> Sent: Wednesday, October 31, 2018 5:52 PM
>>>> To: Andrzej Ostruszka <amo at semihalf.com>; ovs-
>> discuss at openvswitch.org
>>>> Cc: Ophir Munk <ophirmu at mellanox.com>
>>>> Subject: RE: [ovs-discuss] OvS using newer DPDK
>>>>
>>>>> Hello all,
>>>>>
>>>>> I remember some time ago there was topic raised here about new LTS
>>>>> release.  I'd like to ask related question - what version of DPDK
>>>>> will it be based on?  18.11 (which is going to be new LTS release of
>> DPDK)?
>>>>>
>>>>
>>>> Yes, the plan would be ideally to move to DPDK 18.11.
>>>>
>>>>> If it is then is there anybody already working on that?
>>>>
>>>> Yes, the dpdk_latest branch was setup for this purpose.
>>>>
>>>> There are patches submitted to move OVS to use DPDK 18.08 first. From
>>>> there a new set of patches will be created to move to DPDK 18.11.
>>>> Once there is agreement and sign off from the OVS DPDK community we
>>>> would look to apply those to the OVS master branch in time for the
>>>> OVS 2.11 release.
>>>>
>>>>>
>>>>> I'm asking these questions since I've nailed the reason for getting
>>>>> OvS crashes on Marvell Armada 8K board.  They are while attempting
>>>>> to set MTU and there are some patches affecting MTU/MRU
>> calculations
>>>>> that
>>>> might help.
>>>>
>>>> Are these patches targeted at OVS project or the DPDK project?
>>>>
>>>>> So basically I might attempt to backport them or try to get OvS
>>>>> working with newer DPDK.
>>>>
>>>> OVS is moving towards using DPDK LTS releases only for OVS releases
>>>> and the master branch.
>>>>
>>>> If the patches target DPDK then they could be backported to the
>>>> relevant DPDK LTS releases. Once in place there you could also
>>>> backport support to OVS 2.9 and OVS 2.10 which use DPDK 17.11.
>>>>
>>>>> Since I prefer the latter I would like to join somebody doing this
>>>>> update (I don't feel comfortable enough with OvS to do that on my
>>>>> own).
>>>>
>>>> Ok sure, there is not a patch to make DPDK use 18.11 yet. That's in
>> progress.
>>>> I've cc'd Ophir who has been looking at this to date. Once there is a
>>>> patch for
>>>> 18.11 if you could test it with the Marvell device that would be great help.
>>>>
>>>> Thanks
>>>> Ian
>>>>>
>>>>> Best regards
>>>>> Andrzej
>>>>> _______________________________________________
>>>>> discuss mailing list
>>>>> discuss at openvswitch.org
>>>>>
>>>>
>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fma
>>>> i
>>>>> l.openvswitch.org%2Fmailman%2Flistinfo%2Fovs-
>>>> discuss&amp;data=02%7C01%
>>>>>
>>>>
>> 7Cophirmu%40mellanox.com%7C331523e48ebe430445d008d63f48bffd%7C
>>>> a652971c
>>>>>
>>>>
>> 7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636765979023036325&amp;sda
>>>> ta=WbdP%2
>>>>>
>>>>
>> FAlmdnLB%2FkX1DeK%2F9vHN3oaBD2DWrXKyG%2Bc7uzQ%3D&amp;reserv
>>>> ed=0
>>>
>>>