[ovs-discuss] [PATCH] [ovs-dev] [PATCH] QinQ: support more vlan headers.

Lilijun (Jerry, Cloud Networking) jerry.lilijun at huawei.com
Fri Sep 7 02:51:25 UTC 2018


Hi all,

In my test, vlan-limit is set to 0 that means unlimited the count of vlan
headers.
ovs-vsctl set Open_vSwitch . other_config:vlan-limit=0

But in fact the macro FLOW_MAX_VLAN_HEADERS is defined as 2, so we can
only support max two vlan headers. It doesn't work as the config vlan-limit's
description.

So, when VM sends a packet already with two vlan headers, the vport configured with
qinq mode can't add another s-vlan headers. FLOW_MAX_VLAN_HEADERS need to
be larger to support more vlan headers.

Thanks

Change-Id: I8449e308d406ce3757b43a2636ff0f326ca12a9d
Signed-off-by: Lilijun <jerry.lilijun at huawei.com>
---
include/openvswitch/flow.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/openvswitch/flow.h b/include/openvswitch/flow.h
index 5d2cf09..b42710c 100644
--- a/include/openvswitch/flow.h
+++ b/include/openvswitch/flow.h
@@ -72,7 +72,7 @@ const char *flow_tun_flag_to_string(uint32_t flags);
  *
  * We require this to be a multiple of 2 so that vlans[] in struct flow is a
  * multiple of 64 bits. */
-#define FLOW_MAX_VLAN_HEADERS 2
+#define FLOW_MAX_VLAN_HEADERS 4
BUILD_ASSERT_DECL(FLOW_MAX_VLAN_HEADERS % 2 == 0);
 /* Legacy maximum VLAN headers */
--
________________________________
华为技术有限公司 Huawei Technologies Co., Ltd.
[Company_logo]
个人签名:Just Do It!
电子邮件:jerry.lilijun at huawei.com
________________________________
 本邮件及其附件含有华为公司的保密信息,仅限于发送给上面地址中列出的个人或群组。禁
止任何其他人以任何形式使用(包括但不限于全部或部分地泄露、复制、或散发)本邮件中
的信息。如果您错收了本邮件,请您立即电话或邮件通知发件人并删除本邮件!
This e-mail and its attachments contain confidential information from HUAWEI, which
is intended only for the person or entity whose address is listed above. Any use of the
information contained herein in any way (including, but not limited to, total or partial
disclosure, reproduction, or dissemination) by persons other than the intended
recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by
phone or email immediately and delete it!

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-discuss/attachments/20180907/8f39364e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 5474 bytes
Desc: image001.png
URL: <http://mail.openvswitch.org/pipermail/ovs-discuss/attachments/20180907/8f39364e/attachment.png>


More information about the discuss mailing list