[ovs-discuss] [PATCH] [ovs-dev] [PATCH] QinQ: support more vlan headers.

Ben Pfaff blp at ovn.org
Fri Sep 7 04:19:54 UTC 2018


On Fri, Sep 07, 2018 at 02:54:18AM +0000, Lilijun (Jerry, Cloud Networking) wrote:
> Hi all,
> 
> In my test, vlan-limit is set to 0 that means unlimited the count of vlan
> headers.
> ovs-vsctl set Open_vSwitch . other_config:vlan-limit=0
> 
> But in fact the macro FLOW_MAX_VLAN_HEADERS is defined as 2, so we can
> only support max two vlan headers. It doesn't work as the config vlan-limit's
> description.
> 
> So, when VM sends a packet already with two vlan headers, the vport configured with
> qinq mode can't add another s-vlan headers. FLOW_MAX_VLAN_HEADERS need to
> be larger to support more vlan headers.

Doesn't apply.

When I apply it by hand, the build fails:

In file included from ../lib/cfm.c:26:
In file included from ../lib/dp-packet.h:32:
In file included from ../lib/flow.h:30:
../include/openvswitch/flow.h:167:1: error: static_assert failed "offsetof(struct flow, igmp_group_ip4) + sizeof(uint32_t) == sizeof(struct flow_tnl) + sizeof(struct ovs_key_nsh) + 300 && FLOW_WC_SEQ == 41"
../include/openvswitch/compiler.h:255:33: note: expanded from macro 'BUILD_ASSERT_DECL'


More information about the discuss mailing list