[ovs-discuss] Flow Monitoring

Ashish Varma avarma at vmware.com
Tue May 28 17:45:27 UTC 2019


Please see inline as [Ashish]

On 5/23/19, 8:39 PM, "Ben Pfaff" <blp at ovn.org> wrote:

    On Thu, May 23, 2019 at 10:46:40PM -0400, Vasu Dasari wrote:
    > Thanks for digging into this. My comments inline. I am sorry that I had to
    > differ from your analysis.
    
    Thank you for the correction.  You are right: this is buggy.  OVS does
    not and should not claim to support flow monitoring except as an OVS
    extension.  I knew that the support was not there before, although I
    though we had added it recently, but I did not know that OVS tried
    to support it before.
    
    Ashish submitted a patch back in January to add full support:
    https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fpipermail%2Fovs-dev%2F2019-January%2F355778.html&amp;data=02%7C01%7Cavarma%40vmware.com%7C0fab9e113fa546ca1f6908d6dff9689a%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636942659632360052&amp;sdata=NzppkYBtVATlOVD1Ymr8KU7H51o0D2ERfYH9Ll9YtDM%3D&amp;reserved=0
    and we discussed it a bit:
    https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fpipermail%2Fovs-dev%2F2019-February%2F355901.html&amp;data=02%7C01%7Cavarma%40vmware.com%7C0fab9e113fa546ca1f6908d6dff9689a%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636942659632360052&amp;sdata=ia8esjGnd7lS9xO6y1HsAOpTBXmsj98u2HWb%2Bf3EvJw%3D&amp;reserved=0
    but I do not know of a v3.
    
    Ashish, is there a newer version of this patch?
    [Ashish: There was a bug in the related code path which is related to 'usable_protocol' variable not being set and used properly in the existing code.
I will have the v2 patch for this bug this week and then a v3 for the flow monitor as well. The fix for the bug is a pre-requisite for the Flow Monitor v3 patch. Sorry it took so long.] 

    However, for 2.11 and earlier, I expect that the best we can do is to
    simply change this request so that it provokes an error.
    



More information about the discuss mailing list