[ovs-discuss] xml parsing issues with lib/db-ctl-base.xml

Ilya Maximets i.maximets at ovn.org
Wed Feb 3 19:15:00 UTC 2021


On 2/3/21 7:22 PM, Ben Pfaff wrote:
> On Wed, Feb 03, 2021 at 06:02:02PM +0100, Ilya Maximets wrote:
>>> On Tue, Feb 02, 2021 at 05:02:54PM -0500, Flavio Fernandes wrote:
>>>> Hi Ben,
>>>>
>>>> compiling ovn master with ovs master is upset because of an xml issue in the file:  lib/db-ctl-base.xml
>>>>
>>>> Could you help fixing it, please?
>>>
>>> Oops, I applied this:
>>
>> <sinp>
>>
>> Thanks, Ben for fixing this.  I missed that typo during review.
>>
>> I was trying to figure out why we didn't catch this issue in OVS build
>> and I found that we actually have 2 copies of several parts of manpages.
>> One .man file and one .xml file for following docs:
>>
>>         lib/common.xml
>>         lib/daemon.xml
>>         lib/db-ctl-base.xml
>>         lib/ssl.xml
>>         lib/ssl-bootstrap.xml
>>         lib/ssl-peer-ca-cert.xml
>>         lib/table.xml
>>         lib/vlog.xml
>>         lib/unixctl.xml
>>
>> All these files were added to be used in OVN man pages and has no users in
>> OVS code base.  We should, probably, generate man pages from these xml files
>> instead of having *.man duplicates to catch this kind of issues.
> 
> At one point I was trying to convert all the manpages to XML.  I stopped
> before I finished.
> 
> These days, .rst files might be a better solution.

Yes, probably.  Right now we have all 3 types of manpage sources
(man, xml and rst).  It'll be good to unify them, i.e. convert all
to rST.  Looks like a big chunk of work, though.

While we're on this topic, It would be great if you could take a
quick look at this patch:
  http://patchwork.ozlabs.org/project/openvswitch/patch/20210129140305.1392406-1-i.maximets@ovn.org/

Best regards, Ilya Maximets.


More information about the discuss mailing list