[ovs-git] Open vSwitch: brcompat: Remove no-longer-needed #includes. (citrix)

nicira-dev at nicira.com nicira-dev at nicira.com
Fri Aug 7 22:12:54 UTC 2009

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, citrix has been updated
       via  c170afc1dbdcf2e5adb1a0d2da6635bd81b7126f (commit)
       via  6dac2b9ed9d77a92f53258f694117fa8b989aacb (commit)
       via  35c979bff42010f54842d00bec8836f1d3f30545 (commit)
       via  db322751d8bba32152e89eea476cb47a010616b1 (commit)
       via  ae1281cfa015b710817822002f21a4f6195cb740 (commit)
       via  621fd03a0717358fb8600a8bacb99782ab181005 (commit)
       via  41e754bcb40f78f5a2a790a4b196433cd1afa304 (commit)
       via  7f42c1d707c65befb9d92bebae069e4f4b0be1fb (commit)
       via  c338e47fbef2ce1354acbd9f521196dea3fe93f5 (commit)
       via  f86e18b739d8f6f8f714a4ce0cb38f6ac58b1108 (commit)
      from  0ceda58c0697cb3c1ad8b85dc21d105049f92129 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c170afc1dbdcf2e5adb1a0d2da6635bd81b7126f
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c170afc1dbdcf2e5adb1a0d2da6635bd81b7126f
Author: Ben Pfaff <blp at nicira.com>
brcompat: Remove no-longer-needed #includes.

commit 6dac2b9ed9d77a92f53258f694117fa8b989aacb
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=6dac2b9ed9d77a92f53258f694117fa8b989aacb
Author: Ben Pfaff <blp at nicira.com>
brcompat: Remove requirement that that no datapaths exist at load time.
We previously required that brcompat_mod be loaded before any datapaths
were created, because creation and destruction of datapaths and ports
differed when brcompat_mod was loaded, but the latter is no longer the
case so there is no reason for the former anymore.

commit 35c979bff42010f54842d00bec8836f1d3f30545
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=35c979bff42010f54842d00bec8836f1d3f30545
Author: Ben Pfaff <blp at nicira.com>
vswitchd: Support creating fake bond device interfaces.
Citrix QA scripts expect that "brctl show" shows a bond interface for each
bond that is added to a bridge.  The only way to do that without modifying
brctl itself is to create an actual network device by that name, so this
commit adds a new bonding configuration key that causes an internal
device by the name of the bond to be created.

This feature is also necessary, but not sufficient, to allow XenCenter to
accurately show the link status and statistics of bridges (bug #1363).

This new configuration key is intentionally undocumented, because I don't
want anyone to use it.

Bug NIC-19.

commit db322751d8bba32152e89eea476cb47a010616b1
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=db322751d8bba32152e89eea476cb47a010616b1
Author: Ben Pfaff <blp at nicira.com>
brcompat: Move BRCTL_GET_BRIDGES, BRCTL_GET_PORT_LIST into userspace.
The Citrix QA scripts assume that "brctl show" will show a topology as if
the Linux bridge were still in use; that is, as if there were one bridge
per VLAN and as if bonds were network devices of their own instead of
separate devices.  However, we were showing the datapath topology, i.e.
all VLANs and bond devices lumped together into a single datapath.  This
commit fixes the VLAN end of the problem, by moving the implementation of
the ioctls that brctl uses into userspace in ovs-brcompatd and putting the
necessary translation logic into ovs-brcompatd.

By itself, this commit does not fix the problem for bonds: the port name
for a bond does not (normally) under Open vSwitch exist as an actual
Linux network device, and thus it has no ifindex, and so ovs-brcompatd
can't pass it back to the kernel to report to brctl.  This fix will have
to wait for another commit.

Bug NIC-19.

commit ae1281cfa015b710817822002f21a4f6195cb740
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=ae1281cfa015b710817822002f21a4f6195cb740
Author: Ben Pfaff <blp at nicira.com>
brcompatd: Factor code out of handle_fdb_query_cmd().
An upcoming commit wants to do the same thing in another place, so break
the logic into a function.

commit 621fd03a0717358fb8600a8bacb99782ab181005
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=621fd03a0717358fb8600a8bacb99782ab181005
Author: Ben Pfaff <blp at nicira.com>
brcompatd: Fix handle_fdb_query_cmd() return value on error.
handle_fdb_query_cmd() should return an error when an error occurs, but
in this case it was always returning 0, because error is known to have
value 0 at this point.

Nothing really uses the return value here, and so eventually it would make
sense to just change the return type here and in the rest of the
handle_*() functions to void.

commit 41e754bcb40f78f5a2a790a4b196433cd1afa304
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=41e754bcb40f78f5a2a790a4b196433cd1afa304
Author: Ben Pfaff <blp at nicira.com>
brcompatd: Break send_reply() up into more functions for flexibility.
Upcoming commits will require sending Netlink messages to the kernel that
have additional attributes.  Instead of adding more arguments to
send_reply() to handle these, it's cleaner to break up send_reply() into
two functions and let the caller add those attributes itself.

commit 7f42c1d707c65befb9d92bebae069e4f4b0be1fb
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=7f42c1d707c65befb9d92bebae069e4f4b0be1fb
Author: Ben Pfaff <blp at nicira.com>
brcompatd: Make parse_command() parse commands without dp arguments.
The BRCTL_GET_BRIDGES ioctl is going to move to userspace, but that ioctl
doesn't provide a bridge name as argument, so we need to support that.

commit c338e47fbef2ce1354acbd9f521196dea3fe93f5
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c338e47fbef2ce1354acbd9f521196dea3fe93f5
Author: Ben Pfaff <blp at nicira.com>
svec: New convenience macro SVEC_FOR_EACH.

commit f86e18b739d8f6f8f714a4ce0cb38f6ac58b1108
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=f86e18b739d8f6f8f714a4ce0cb38f6ac58b1108
Author: Ben Pfaff <blp at nicira.com>
datapath: Unexport functions only used in openvswitch_mod.


Summary of changes:
 datapath/brcompat.c                                |  112 +++-----
 datapath/dp_dev.c                                  |    2 -
 include/openvswitch/brcompat-netlink.h             |    7 +-
 lib/svec.h                                         |    9 +
 vswitchd/bridge.c                                  |   27 ++-
 vswitchd/ovs-brcompatd.c                           |  279 ++++++++++++++++----
 .../opt_xensource_libexec_interface-reconfigure    |    1 +
 7 files changed, 306 insertions(+), 131 deletions(-)

Open vSwitch

More information about the git mailing list