[ovs-git] Open vSwitch: secchan: Clarify log message about failing open. (citrix)

nicira-dev at nicira.com nicira-dev at nicira.com
Tue Aug 11 17:05:23 UTC 2009

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, citrix has been updated
       via  5ec6690ca447dd25e3d04b60ca66d2e6e1cf37f2 (commit)
      from  63920cb960ffe2c494f73982f6ea073a4dc3460d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5ec6690ca447dd25e3d04b60ca66d2e6e1cf37f2
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=5ec6690ca447dd25e3d04b60ca66d2e6e1cf37f2
Author: Justin Pettit <jpettit at nicira.com>
secchan: Clarify log message about failing open.
In commit e10dfcf357 "rconn: Be pickier about what constitutes a
successful connection", the criteria for determining a successful
OpenFlow connection was tightened.  When rconn connects at a socket
level, it prints messages stating that it "connected" and the switch is
taken out of fail-open mode.  If it is determined that it is not a
"successful" OpenFlow connection, then the connection is closed and
fail-open is re-enabled.  When this occurs, fail-open logs the following
potentially confusing message:

    Could not connect to controller for XXX seconds, failing open

Where XXX is the number of seconds since the last "succesful" connection
rather than simple socket-level connection.  This commit changes the
message to:

    Could not establish OpenFlow channel to controller for XXX
    seconds, failing open

Bug #1163


Summary of changes:
 secchan/fail-open.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

Open vSwitch

More information about the git mailing list