[ovs-git] Open vSwitch: xenserver: Completely ignore datapath devices for renaming purposes. (citrix)

nicira-dev at nicira.com nicira-dev at nicira.com
Wed Aug 19 20:44:35 UTC 2009

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, citrix has been updated
       via  9d04e270a8749d8dc54cef860abfc8c95823ff28 (commit)
       via  b78a7336a3318a3c348004760bac3e0057b9e9d1 (commit)
      from  af616f686b851c7e31ee48f16e7ae7df6f550553 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9d04e270a8749d8dc54cef860abfc8c95823ff28
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=9d04e270a8749d8dc54cef860abfc8c95823ff28
Author: Ben Pfaff <blp at nicira.com>
xenserver: Completely ignore datapath devices for renaming purposes.
Commit 2bb451b69 "xenserver: Rename network devices to match MAC addresses
of physical PIFs" started renaming network devices so that they match
the MAC address that we expect them to have.  This worked OK at the time.

Commit 35c979bff "vswitchd: Support creating fake bond device interfaces"
later started creating fake bond devices to make the Citrix QA scripts

Unfortunately these commits interact badly: the bond devices created by
the latter commit are sometimes chosen as the physical devices to be
renamed over the physical PIF device names.  This is because we do allow
datapath internal ports to be chosen as "physical devices" as a last
resort.  This commit reverses this decision, eliminating that possibility.
This probably won't become a problem unless somehow we encounter a physical
Ethernet card driver that lacks a queue, but that is unlikely since the
performance would be awful.

commit b78a7336a3318a3c348004760bac3e0057b9e9d1
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=b78a7336a3318a3c348004760bac3e0057b9e9d1
Author: Ben Pfaff <blp at nicira.com>
datapath: Additional fixes for datapath device renaming.
Commit c874dc6d6b "secchan: Fix behavior when a network device is renamed."
fixed a crash in the datapath when network devices within a datapath were
renamed.  However, this missed the case where the device that was renamed
was a datapath's internal port: these devices have their br_port members
set to NULL, so we have to determine that they belong to a datapath another
way.  This commit does so.

This commit also changes the initialization order in dp_dev_create().
Otherwise, dp_device_event() will dereference null when it is called via
register_netdevice(), because the newly created device is a datapath device
but its members are not yet initialized.


Summary of changes:
 datapath/dp_dev.c                                  |    9 +++++----
 datapath/dp_notify.c                               |    9 +++++++--
 .../opt_xensource_libexec_interface-reconfigure    |   10 +++-------
 3 files changed, 15 insertions(+), 13 deletions(-)

Open vSwitch

More information about the git mailing list