[ovs-git] Open vSwitch: xenserver: Fix "brctl show" compatibility by introducing "brctl" wrapper. (citrix)

nicira-dev at nicira.com nicira-dev at nicira.com
Wed Aug 19 22:10:48 UTC 2009

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, citrix has been updated
       via  8521345b51ef456819412b175538555eb9f3c152 (commit)
      from  9d04e270a8749d8dc54cef860abfc8c95823ff28 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8521345b51ef456819412b175538555eb9f3c152
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=8521345b51ef456819412b175538555eb9f3c152
Author: Ben Pfaff <blp at nicira.com>
xenserver: Fix "brctl show" compatibility by introducing "brctl" wrapper.
Bug NIC-19, which reported that "brctl show" did not format its output in
the way expected by Citrix QA scripts, was believed fixed by commit
35c979bff4 "vswitchd: Support creating fake bond device interfaces."
Unfortunately, this commit was not tested on a XenServer before it was
committed.  Due to differences in the actual test environment and the
XenServer environment, which have different versions of the bridge-utils
package that contains brctl, that commit did not fix the problem observed
by Citrix QA.  In particular, the XenServer brctl uses sysfs to obtain
the information displayed by "brctl show", but the previous commit only
fixed up the information output by the bridge ioctls.

The natural way to fix this problem would be to fix up the sysfs support
as well.  I started out along that path, but became bogged down in all
the details of the kernel sysfs.

This commit takes an alternate approach, by introducing a wrapper around
the system brctl binary that implements "brctl show" itself and delegates
all other functionality to the original binary (in a different location).
This will not fix tools that do not call into brctl, but to the best of
my knowledge there are no such tools used in the Citrix QA process.

Thanks to Justin and Reid for much feedback.

Bug NIC-19.


Summary of changes:
 xenserver/README           |    5 +
 xenserver/automake.mk      |    1 +
 xenserver/usr_sbin_brctl   |  181 ++++++++++++++++++++++++++++++++++++++++++++
 xenserver/vswitch-xen.spec |   30 ++++++-
 4 files changed, 213 insertions(+), 4 deletions(-)
 create mode 100755 xenserver/usr_sbin_brctl

Open vSwitch

More information about the git mailing list