[ovs-git] Open vSwitch: vswitchd: Mirror nothing, not everything, if mirror ports don't exist. (citrix)

dev at openvswitch.org dev at openvswitch.org
Wed Aug 26 21:14:24 UTC 2009

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, citrix has been updated
       via  e0c27cffbc9b93f90c764e374f6944cb893295a3 (commit)
       via  274de4d20f450cc4cf83500d806f8b361f1387a5 (commit)
      from  5b4994cd75470b694628fb76eb0fb01869eaac9a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e0c27cffbc9b93f90c764e374f6944cb893295a3
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e0c27cffbc9b93f90c764e374f6944cb893295a3
Author: Ben Pfaff <blp at nicira.com>
vswitchd: Mirror nothing, not everything, if mirror ports don't exist.
If all of the ports specified as mirror selection criteria actually do not
exist, then until now the bridge would mirror all incoming packets (on
specified VLAN(s), if any).  This matches the behavior that occurs if no
mirror selection ports were specified at all, and so it makes a certain
amount of logical sense.

But it is far more likely that the user simply misspelled a port name, or
specified the name of a port that does not always exist.  In fact we have
seen this behavior in practice when the controller has not caught up to
the switch's current configuration.  So this commit changes the bridge to
instead disable a mirror if ports are specified and none of those ports

Bug #1904.

commit 274de4d20f450cc4cf83500d806f8b361f1387a5
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=274de4d20f450cc4cf83500d806f8b361f1387a5
Author: Ben Pfaff <blp at nicira.com>
vswitchd: Avoid output port explosion with mirrors that output to VLANs.
compose_dsts() was updating the VLAN of packets sent to VLAN mirrors
before it changed the VLAN value, but of course it's the final VLAN value
that actually matters.

Thanks to Reid for his good work tracking this one down.

Bug #1898.


Summary of changes:
 vswitchd/bridge.c |   15 +++++++++++++--
 1 files changed, 13 insertions(+), 2 deletions(-)

Open vSwitch

More information about the git mailing list