[ovs-git] Open vSwitch: ovs-vsctl: Capitalize names of global constants but not variables. (master)

dev at openvswitch.org dev at openvswitch.org
Mon Nov 9 23:02:43 UTC 2009

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  01b528c1b7af38678f29a6b21c0bc220560c97f7 (commit)
       via  3fbe1d307e27ed99528d83cf866c7df497e58b77 (commit)
      from  fde05aded2906e113d02aa13d207d9a6e3e0ea99 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 01b528c1b7af38678f29a6b21c0bc220560c97f7
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=01b528c1b7af38678f29a6b21c0bc220560c97f7
Author: Ben Pfaff <blp at nicira.com>
ovs-vsctl: Capitalize names of global constants but not variables.
Conforms to the Google style guide for Python.

Reported by Justin.

commit 3fbe1d307e27ed99528d83cf866c7df497e58b77
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=3fbe1d307e27ed99528d83cf866c7df497e58b77
Author: Ben Pfaff <blp at nicira.com>
Make ovs-appctl easier to use and synchronize its interface with ovs-vsctl.
It is inconvenient to type the whole path to the Unix daemon socket when
using ovs-appctl.  Allow the name of the daemon to be used instead when
a pidfile exists in the default location, and contact ovs-vswitchd by

Also, the various options for manipulating vlog were invented before the
general-purpose command mechanism existed.  Get rid of all of the action
options in favor of just specifying the command to be executed as
non-option arguments.

Finally, there simply wasn't much value in allowing multiple targets or
options to be specified; these variations were never used in practice.  So
simplify the interface by making it one target, one action per invocation.

Also, make ovs-vsctl use the same syntax for its --target option.

Based on work by Justin Pettit.


Summary of changes:
 INSTALL.Linux                       |   10 +-
 debian/openvswitch-switch.logrotate |    2 +-
 lib/unixctl.c                       |    2 +-
 lib/vlog-unixctl.man                |    4 +-
 lib/vlog.man                        |    4 +-
 utilities/ovs-appctl.8.in           |  123 +++++++++--------
 utilities/ovs-appctl.c              |  255 ++++++++++++++++-------------------
 utilities/ovs-vsctl.8.in            |   38 +++---
 utilities/ovs-vsctl.in              |   47 +++----
 vswitchd/ovs-brcompatd.8.in         |    6 +-
 vswitchd/ovs-brcompatd.c            |    5 +-
 xenserver/etc_init.d_vswitch        |    9 +-
 12 files changed, 234 insertions(+), 271 deletions(-)

Open vSwitch

More information about the git mailing list