[ovs-git] Open vSwitch: secchan: Better tolerate failing controller admission control in fail-open. (citrix)

[dev at openvswitch.org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, citrix has been updated
       via  7778bd15dacc1e410b60ff6ec2996c475a875e6e (commit)
       via  372179d4f4a1dc6113bc4ea60cee76cb354e22f4 (commit)
       via  b9e8b45a3936441bd0fd1fd156cae498bf72cac8 (commit)
      from  72aa493e2fb881d873c82d31bc4b585dd608db48 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7778bd15dacc1e410b60ff6ec2996c475a875e6e
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=7778bd15dacc1e410b60ff6ec2996c475a875e6e
Author: Ben Pfaff <blp at nicira.com>
		
secchan: Better tolerate failing controller admission control in fail-open.
		
When the switch is configured to connect to a controller that accepts
connections, waits a few seconds, and then disconnects without setting up
flows, currently this causes "fail-open" to flush the flow table and
stop setting up new flows during the connection duration.  This is OK if
it happens once, but it can easily happen every 8 seconds with typical
backoff settings, and that isn't so great.

This commit changes fail-open to only flush the flow table once the switch
appears to have been admitted by the controller, which prevents these
frequent network interruptions.

Thanks to Jesse Gross for especially valuable feedback.

QA notes: Behavior in fail-open and especially behavior with a controller
that rejects the switch after it connects needs to be re-tested.  The
ovs-controller --mute switch added by this commit is one simple way to
create such a controller.

CC: Peter Balland <peter at nicira.com>

Bug #1695.  Bug #2055.


commit 372179d4f4a1dc6113bc4ea60cee76cb354e22f4
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=372179d4f4a1dc6113bc4ea60cee76cb354e22f4
Author: Ben Pfaff <blp at nicira.com>
		
Factor out code for composing OFPT_PACKET_IN messages.
		
Currently only ofproto.c ever composes OFPT_PACKET_IN messages, but some
upcoming code wants to do the same thing, so factor this out into a new
function to avoid code duplication.


commit b9e8b45a3936441bd0fd1fd156cae498bf72cac8
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=b9e8b45a3936441bd0fd1fd156cae498bf72cac8
Author: Ben Pfaff <blp at nicira.com>
		
Factor out code for composing benign packets.
		
The bonding code in vswitch sends out gratuitous learning packets that
are supposed to teach switches but not cause anything else to happen on
the network.  Some upcoming code wants to synthesize packets with similar
properties, so factor this code into a new function so that it can be
used in both places.


-----------------------------------------------------------------------

Summary of changes:
 lib/automake.mk               |    1 +
 lib/packets.c                 |   58 +++++++++++++++++
 lib/packets.h                 |    7 ++
 lib/rconn.c                   |   21 ++++--
 lib/rconn.h                   |    1 +
 lib/vconn.c                   |   22 ++++++
 lib/vconn.h                   |    3 +
 secchan/fail-open.c           |  142 +++++++++++++++++++++++++++++++++++------
 secchan/fail-open.h           |    8 ++
 secchan/ofproto.c             |   66 +++++++++++++------
 secchan/pktbuf.c              |   63 ++++++++++++++++++-
 secchan/pktbuf.h              |    1 +
 utilities/ovs-controller.8.in |    7 ++
 utilities/ovs-controller.c    |   14 ++++-
 vswitchd/bridge.c             |   22 +------
 15 files changed, 364 insertions(+), 72 deletions(-)
 create mode 100644 lib/packets.c


hooks/post-receive
-- 
Open vSwitch