[ovs-git] Open vSwitch: datapath: Don't hold dp_mutex when setting internal devs MTU. (master)

[dev at openvswitch.org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  d8b5d43a04fba8ba09d5bb3c745808964f371d80 (commit)
      from  59a81d829017956100170f9499dc690613fc1f6f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d8b5d43a04fba8ba09d5bb3c745808964f371d80
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=d8b5d43a04fba8ba09d5bb3c745808964f371d80
Author: Jesse Gross <jesse at nicira.com>
		
datapath: Don't hold dp_mutex when setting internal devs MTU.
		
We currently acquire dp_mutex when we are notified that the MTU
of a device attached to the datapath has changed so that we can
set the internal devices to the minimum MTU.  However, it is not
required to hold dp_mutex because we already have RTNL lock and it
causes a deadlock, so don't do it.

Specifically, the issue is that DP mutex is acquired twice: once in
dp_device_event() before calling set_internal_devs_mtu() and then
again in internal_dev_change_mtu() when it is actually being changed
(since the MTU can also be set directly).  Since it's not a recursive
mutex, deadlock.


-----------------------------------------------------------------------

Summary of changes:
 datapath/datapath.c           |    5 ++---
 datapath/dp_notify.c          |    5 +----
 datapath/vport-internal_dev.c |    8 +-------
 3 files changed, 4 insertions(+), 14 deletions(-)


hooks/post-receive
-- 
Open vSwitch