[ovs-git] Open vSwitch: ofproto: Improve OFPT_FLOW_MOD error reporting. (wdp)

dev at openvswitch.org dev at openvswitch.org
Fri Aug 20 17:37:23 UTC 2010

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, wdp has been updated
       via  f669e7f77b8261a0ded00bdc76aad46b112d2819 (commit)
       via  ce4e5963accb3655651170cc82f23c4745036826 (commit)
       via  2e3a6ded2636b27c0d5affe3f83da08799791c1f (commit)
       via  e640c1c497dca270356d1597fa0be12374721e1c (commit)
       via  10ce338a32faeb6b4f7b69db79aa24de8c851640 (commit)
      from  78661a5ed344f6f4c3d45d64662a74947b31435d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f669e7f77b8261a0ded00bdc76aad46b112d2819
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=f669e7f77b8261a0ded00bdc76aad46b112d2819
Author: Ben Pfaff <blp at nicira.com>
ofproto: Improve OFPT_FLOW_MOD error reporting.
Error reporting to the controller for "flow_mod" operations was poor
because WDP was reporting errors as Unix errno values and nothing was
translating them into OpenFlow errors to send to the controller.  This
commit fixes the problem by making the functions in question instead use
OpenFlow error numbers and, in cases where there is no appropriate number,
using a vendor extension error number.

commit ce4e5963accb3655651170cc82f23c4745036826
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=ce4e5963accb3655651170cc82f23c4745036826
Author: Ben Pfaff <blp at nicira.com>
ofp-util: Add infrastructure for vendor extensions to OpenFlow error codes.

commit 2e3a6ded2636b27c0d5affe3f83da08799791c1f
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=2e3a6ded2636b27c0d5affe3f83da08799791c1f
Author: Ben Pfaff <blp at nicira.com>
ofproto: Propagate OpenFlow OFPT_FLOW_MOD errors to controller.
Errors can occur during flow table modifications requested via OpenFlow
OFPT_FLOW_MOD commands, but ofproto was in most cases failing to report
these errors back to the controller using OpenFlow error codes.

Reported-by: Tom Everman <teverman at google.com>

commit e640c1c497dca270356d1597fa0be12374721e1c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e640c1c497dca270356d1597fa0be12374721e1c
Author: Ben Pfaff <blp at nicira.com>
Make flow table iteration functions propagate return values to caller.
The following commit will propagate errors from OpenFlow flow table
operations to the OpenFlow controller.  To do so efficiently in cases where
the error occurs during a flow table iteration, it makes sense to stop
iterating as soon as an error occurs.  This commit makes this possible.

commit 10ce338a32faeb6b4f7b69db79aa24de8c851640
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=10ce338a32faeb6b4f7b69db79aa24de8c851640
Author: Ben Pfaff <blp at nicira.com>
nicira-ext: Remove unused macro.


Summary of changes:
 include/openflow/nicira-ext.h |   69 +++++++++++++++++++++-
 lib/classifier.c              |   57 ++++++++++++++----
 lib/classifier.h              |   10 ++--
 lib/ofp-util.c                |   90 +++++++++++++++++++++++++++++
 lib/ofp-util.h                |  110 +++++++++++++++++++++++++++---------
 ofproto/ofproto.c             |  127 ++++++++++++++++++++---------------------
 ofproto/wdp-provider.h        |   49 ++++++++++++----
 ofproto/wdp-xflow.c           |   37 +++++++-----
 ofproto/wdp.c                 |    9 ++-
 ofproto/wdp.h                 |   14 +++--
 tests/test-classifier.c       |    3 +-
 11 files changed, 426 insertions(+), 149 deletions(-)

Open vSwitch

More information about the git mailing list