[ovs-git] Open vSwitch: gre: Don't require incoming checksum. (master)

dev at openvswitch.org dev at openvswitch.org
Sat Aug 21 02:43:48 UTC 2010


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  16e9d4f64f4ad7adf3e5f619e65a2045282b3969 (commit)
       via  bd1bcd39a51c6110a94392ab1551b36b8df6bc59 (commit)
      from  28eec6e50c32c7e848835232aa321ad8fa30d987 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 16e9d4f64f4ad7adf3e5f619e65a2045282b3969
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=16e9d4f64f4ad7adf3e5f619e65a2045282b3969
Author: Jesse Gross <jesse at nicira.com>
		
gre: Don't require incoming checksum.
		
The current meaning of the GRE checksum option is to include
checksums on transmit and require packets to have them on receive.
In addition, incoming packets with checksums are always validated
regardless of this option.  Requiring checksums on receive creates
surprising behavior and interoperability issues.  This disables the
requirement on receive.  The new behavior is that the sender decides
whether to checksum packets and the receiver will validate packets
with checksums (similar to UDP).

Signed-off-by: Jesse Gross <jesse at nicira.com>


commit bd1bcd39a51c6110a94392ab1551b36b8df6bc59
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=bd1bcd39a51c6110a94392ab1551b36b8df6bc59
Author: Jesse Gross <jesse at nicira.com>
		
gre: Disable checksums by default.
		
GRE checksums aren't really all that useful because they only
add value for the GRE and inner Ethernet header.  However, they
are expensive since they cover the entire packet, even though
most of the data is protected by L3 and L4 checksums.  Therefore
disable checksumming by default to improve performance.  In addition,
since CAPWAP doesn't support checksums this makes it consistent with
GRE.

Signed-off-by: Jesse Gross <jesse at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 datapath/vport-gre.c      |   11 +++--------
 include/openvswitch/gre.h |    3 +--
 lib/netdev-gre.c          |    7 ++-----
 vswitchd/vswitch.xml      |   13 +++++++++----
 4 files changed, 15 insertions(+), 19 deletions(-)


hooks/post-receive
-- 
Open vSwitch




More information about the git mailing list