[ovs-git] Open vSwitch: datapath: Free up flow_extract() return value for reporting errors. (master)

dev at openvswitch.org dev at openvswitch.org
Thu Aug 26 16:17:37 UTC 2010


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  769f8ccd5fe0cbfbf85fb41c42e6c164e21352be (commit)
       via  a31e0e31c6f319b50e0d285117c5d187804a7b2e (commit)
       via  e819fb476255e0b5f9fccb5e9e07691205e1608b (commit)
       via  d9fce1ca2313d608ff7c92b69b3ec54661ab16b0 (commit)
      from  df09921db55b56158d67a770a2d79eb9fb93aaf0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 769f8ccd5fe0cbfbf85fb41c42e6c164e21352be
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=769f8ccd5fe0cbfbf85fb41c42e6c164e21352be
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Free up flow_extract() return value for reporting errors.
		
flow_extract() can fail due to memory allocation errors in pskb_may_pull().
Currently it doesn't return those properly, instead just reporting a bogus
flow to the caller.  But its return value is currently in use for reporting
whether the packet was an IPv4 fragment.  This commit switches to reporting
that in the skb itself so that the return value can be reused to report
errors.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit a31e0e31c6f319b50e0d285117c5d187804a7b2e
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a31e0e31c6f319b50e0d285117c5d187804a7b2e
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Remove skb->len >= ETH_HLEN check from flow_extract().
		
The callers ensure that this is already the case.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit e819fb476255e0b5f9fccb5e9e07691205e1608b
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e819fb476255e0b5f9fccb5e9e07691205e1608b
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Use 'bool' instead of 'int' where appropriate.
		
'bool' is better modern kernel style.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit d9fce1ca2313d608ff7c92b69b3ec54661ab16b0
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=d9fce1ca2313d608ff7c92b69b3ec54661ab16b0
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Use min() instead of open-coding it.
		
Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 datapath/datapath.c |   11 +++++------
 datapath/datapath.h |    2 ++
 datapath/flow.c     |   39 +++++++++++++++++++++++----------------
 3 files changed, 30 insertions(+), 22 deletions(-)


hooks/post-receive
-- 
Open vSwitch




More information about the git mailing list