[ovs-git] Open vSwitch: nx-match: Add tests for error return values for unknown NXM fields. (master)

dev at openvswitch.org dev at openvswitch.org
Tue Dec 7 19:06:10 UTC 2010


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  558d80cbfa30f50512dfba23c7bfcb01130a3de8 (commit)
       via  60d5e0d859c2c04b24cf4283bc764d37911871da (commit)
       via  19e7439c61970cc5066aae601492a2e9b55ffcb7 (commit)
      from  73d67a4355a28ea746358329901aa8da1d02ca2b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 558d80cbfa30f50512dfba23c7bfcb01130a3de8
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=558d80cbfa30f50512dfba23c7bfcb01130a3de8
Author: Ben Pfaff <blp at nicira.com>
		
nx-match: Add tests for error return values for unknown NXM fields.
		


commit 60d5e0d859c2c04b24cf4283bc764d37911871da
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=60d5e0d859c2c04b24cf4283bc764d37911871da
Author: Ben Pfaff <blp at nicira.com>
		
nicira-ext: Clarify comments about 'src' and 'dst' in NXAST_REG actions.
		


commit 19e7439c61970cc5066aae601492a2e9b55ffcb7
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=19e7439c61970cc5066aae601492a2e9b55ffcb7
Author: Ben Pfaff <blp at nicira.com>
		
nicira-ext: Clarify and fix macros to check for NXM metadata registers.
		
The NXM_IS_NX_REG macro didn't check the "hasmask" bit, which meant that it
looked like it was supposed to match both exact and wildcarded NXM headers,
e.g. both NXM_NX_REG0 and NXM_NX_REG0_W.  But exact and wildcarded NXM
headers differ not just in the "hasmask" bit but in the "length" value
also (the wildcarded version's length is twice the exact version's length),
so this was not what it actually did.

The only current users of NXM_IS_NX_REG actually only want to match exact
versions, so this commit makes it only match those.  It also adds a new
NXM_IS_NX_REG_W macro that matches only wildcarded versions.  This new
macro has no users yet, but its existence should help to make it clear that
NXM_IS_NX_REG only matches exact NXM headers.

Reported-by: Natasha Gude <natasha at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 include/openflow/nicira-ext.h |   12 ++++++++----
 lib/nx-match.c                |   41 +++++++++++++++++++++++++++--------------
 tests/ovs-ofctl.at            |   24 ++++++++++++++++++++++++
 3 files changed, 59 insertions(+), 18 deletions(-)


hooks/post-receive
-- 
Open vSwitch




More information about the git mailing list