[ovs-git] Open vSwitch: ofp-util: Improve log messages for bad Nicira extension actions. (master)

dev at openvswitch.org dev at openvswitch.org
Mon Dec 27 17:48:39 UTC 2010


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  abcf9134e459208dc4f73648c284ec5431ad7cb8 (commit)
       via  f43505292156932c376f072faebfa941bc0064ac (commit)
       via  35c4693ab8d10c1271484f39a72751f613cf8de1 (commit)
      from  01ca1bfcbdd315519e7da58052a9c1359f9e72f7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit abcf9134e459208dc4f73648c284ec5431ad7cb8
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=abcf9134e459208dc4f73648c284ec5431ad7cb8
Author: Ben Pfaff <blp at nicira.com>
		
ofp-util: Improve log messages for bad Nicira extension actions.
		
check_action_exact_len() will always report that a Nicira extension action
has type 65535 (OFPAT_VENDOR), which isn't very helpful for debugging.
This introduces a new function that reports the subtype.

Also, log the subtype of unknown Nicira vendor actions.


commit f43505292156932c376f072faebfa941bc0064ac
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=f43505292156932c376f072faebfa941bc0064ac
Author: Ben Pfaff <blp at nicira.com>
		
ofp-util: Upgrade log messages for controller bugs to warning level.
		
All of these messages indicate that there is a bug in the controller.  We
want to know about that, so increase the log level from debug to warning.


commit 35c4693ab8d10c1271484f39a72751f613cf8de1
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=35c4693ab8d10c1271484f39a72751f613cf8de1
Author: Ben Pfaff <blp at nicira.com>
		
ofp-util: Improve log message for bad OpenFlow action length.
		
First, this is an important message since it indicates a bug in the
controller, so log it at warning level instead of debug level--we want to
know about it.

Second, properly byteswap the action type.

Third, use the correct PRIu16 format specified for a uint16_t.


-----------------------------------------------------------------------

Summary of changes:
 lib/ofp-util.c |   67 +++++++++++++++++++++++++++++++++++---------------------
 1 files changed, 42 insertions(+), 25 deletions(-)


hooks/post-receive
-- 
Open vSwitch




More information about the git mailing list