[ovs-git] Open vSwitch: ovs-ofctl: Drop assignment whose value is never used. (next)
dev at openvswitch.org
dev at openvswitch.org
Thu Feb 11 18:39:14 UTC 2010
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".
The branch, next has been updated
via 62ee3464d99c0e37f38b503321cd46181c5c7617 (commit)
via b89d8339252cd330daca7341bbd76c7316080127 (commit)
via 212fe71c79ecb40059d01cbe6f218a5e57144c82 (commit)
via b0ef0551167affac2c406fcdeb2b4130e359f32c (commit)
via 4869f1b170c1741fbc8f81123d0fe5fc1ba3a282 (commit)
via 02ef592c379d359bb447ae5fbb709e485dcb5103 (commit)
via 5fbb4e187d587679882b296211e75a06f791acea (commit)
via 651471fda8df6b3190973a2f048b66448fe90a93 (commit)
via f0f4410a47e20d5c6c8f0e56eb7c8a2a3248248c (commit)
via 141c83fa93693d750f804d5124d960992a723de7 (commit)
via 8b71367c38c9d2e57261fe7f30cbfc1d20b39401 (commit)
via b62aeed2ab06ecb9a3b3a82dc42ebfc2703ef52f (commit)
via 413f274f20bd7e614e144b512b38984d1e9f28b3 (commit)
via f446d59b369ec2c5df79ee3589c50eb22f949a63 (commit)
via 3a919aee4424281cca765741fe8e4c881d535df2 (commit)
from e91087c7f935b74f818739e9a8ec86cc15679cbc (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 62ee3464d99c0e37f38b503321cd46181c5c7617
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=62ee3464d99c0e37f38b503321cd46181c5c7617
Author: Ben Pfaff <blp at nicira.com>
ovs-ofctl: Drop assignment whose value is never used.
Found by Clang (http://clang-analyzer.llvm.org).
commit b89d8339252cd330daca7341bbd76c7316080127
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=b89d8339252cd330daca7341bbd76c7316080127
Author: Ben Pfaff <blp at nicira.com>
ovs-vsctl: Avoid redundant initializations in "add-br" command.
Found by Clang (http://clang-analyzer.llvm.org).
commit 212fe71c79ecb40059d01cbe6f218a5e57144c82
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=212fe71c79ecb40059d01cbe6f218a5e57144c82
Author: Ben Pfaff <blp at nicira.com>
ofproto: Avoid passing indeterminate value to rule_insert().
The 'in_port' argument to rule_insert() is only used if its 'packet'
argument is nonnull, so this is not, strictly speaking, a bug, but it
seems much cleaner.
The default -1 value of in_port matches what pktbuf_retrieve() stores
there on failure.
Found by Clang (http://clang-analyzer.llvm.org).
commit b0ef0551167affac2c406fcdeb2b4130e359f32c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=b0ef0551167affac2c406fcdeb2b4130e359f32c
Author: Ben Pfaff <blp at nicira.com>
ovsdb: Drop write-only variable.
Found by Clang (http://clang-analyzer.llvm.org).
commit 4869f1b170c1741fbc8f81123d0fe5fc1ba3a282
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=4869f1b170c1741fbc8f81123d0fe5fc1ba3a282
Author: Ben Pfaff <blp at nicira.com>
ovs-brcompatd: Use error instead of pointer in handle_fdb_query_cmd().
It is safe to use either value here but as long as we are saving the
error value we might as well use it.
Found by Clang (http://clang-analyzer.llvm.org/).
commit 02ef592c379d359bb447ae5fbb709e485dcb5103
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=02ef592c379d359bb447ae5fbb709e485dcb5103
Author: Ben Pfaff <blp at nicira.com>
sflow: Don't assign value that is never used.
The "error" return from collectors_create() is actually not that
interesting, because there could still be some collectors configured
properly anyhow, so we might as well discard the error return here,
without even assigning it to a variable.
Found by Clang (http://clang-analyzer.llvm.org/).
commit 5fbb4e187d587679882b296211e75a06f791acea
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=5fbb4e187d587679882b296211e75a06f791acea
Author: Ben Pfaff <blp at nicira.com>
vswitchd: Drop assignment whose value is never used in port_reconfigure().
Seems cleaner this way.
Found by Clang (http://clang-analyzer.llvm.org/).
commit 651471fda8df6b3190973a2f048b66448fe90a93
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=651471fda8df6b3190973a2f048b66448fe90a93
Author: Ben Pfaff <blp at nicira.com>
process: Remove pointless, redundant assignments from stream_read().
Found by Clang (http://clang-analyzer.llvm.org/).
commit f0f4410a47e20d5c6c8f0e56eb7c8a2a3248248c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=f0f4410a47e20d5c6c8f0e56eb7c8a2a3248248c
Author: Ben Pfaff <blp at nicira.com>
tests: Remove write-only variables.
Found by Clang (http://clang-analyzer.llvm.org/).
commit 141c83fa93693d750f804d5124d960992a723de7
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=141c83fa93693d750f804d5124d960992a723de7
Author: Ben Pfaff <blp at nicira.com>
ovsdb: Remove write-only variable from parse_body() in log.c.
Found by Clang (http://clang-analyzer.llvm.org/).
commit 8b71367c38c9d2e57261fe7f30cbfc1d20b39401
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=8b71367c38c9d2e57261fe7f30cbfc1d20b39401
Author: Ben Pfaff <blp at nicira.com>
ovsdb: Add default case to ovsdb_mutation_set_execute().
The value of 'error' is indeterminate if m->mutator is not set to a valid
value here, so we should add a default case to handle the exception. It
shouldn't happen, of course.
Found by Clang (http://clang-analyzer.llvm.org/).
commit b62aeed2ab06ecb9a3b3a82dc42ebfc2703ef52f
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=b62aeed2ab06ecb9a3b3a82dc42ebfc2703ef52f
Author: Ben Pfaff <blp at nicira.com>
netdev-linux: Avoid fiddling with indeterminate data.
If we are using netlink to get stats and get_ifindex() fails, then for
an internal network device we will then swap around a bunch of
indeterminate (uninitialized) data values. That won't hurt anything--the
caller will still set them to all-1-bits due to the error--but it still
seems wrong. So this commit avoid it.
Found using Clang (http://clang-analyzer.llvm.org/).
commit 413f274f20bd7e614e144b512b38984d1e9f28b3
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=413f274f20bd7e614e144b512b38984d1e9f28b3
Author: Ben Pfaff <blp at nicira.com>
dhcp: Don't pass NULL to memcmp() even with size 0.
ISO C says that the arguments to memcmp() must be nonnull even if the
size argument is 0, so don't do that.
Found by Clang (http://clang-analyzer.llvm.org).
commit f446d59b369ec2c5df79ee3589c50eb22f949a63
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=f446d59b369ec2c5df79ee3589c50eb22f949a63
Author: Ben Pfaff <blp at nicira.com>
vswitch: Fix uninitialized variable.
The 'ip' variable in this inner "if" statement shadows a variable with
the same name in the enclosing block. The variable in the inner block
is never initialized.
Found by Clang (http://clang-analyzer.llvm.org).
commit 3a919aee4424281cca765741fe8e4c881d535df2
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=3a919aee4424281cca765741fe8e4c881d535df2
Author: Ben Pfaff <blp at nicira.com>
flow: Fix null pointer dereference in flow_from_match().
Found by Clang (http://clang-analyzer.llvm.org).
-----------------------------------------------------------------------
Summary of changes:
lib/dhcp.c | 4 ++--
lib/flow.c | 17 +++++++++--------
lib/netdev-linux.c | 6 ++----
lib/process.c | 6 ++----
ofproto/ofproto-sflow.c | 5 ++---
ofproto/ofproto.c | 4 +++-
ovsdb/log.c | 4 +---
ovsdb/mutation.c | 3 +++
ovsdb/ovsdb-server.c | 4 ++--
tests/test-classifier.c | 10 +++++-----
tests/test-vconn.c | 4 ++--
utilities/ovs-ofctl.c | 2 +-
utilities/ovs-vsctl.c | 5 ++---
vswitchd/bridge.c | 4 ++--
vswitchd/ovs-brcompatd.c | 2 +-
15 files changed, 39 insertions(+), 41 deletions(-)
hooks/post-receive
--
Open vSwitch
More information about the git
mailing list