[ovs-git] Open vSwitch: datapath: Check vswitch_skb_checksum_setup() return code. (master)

[dev at openvswitch.org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  b28c72ba7c992bcd2f5b65be0799a2d9422df21f (commit)
       via  a2377e444a0e0a3f3c6db2502c63cc9545572281 (commit)
      from  db9220c38ee6fd3ff264807e4c32065e5de5140f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b28c72ba7c992bcd2f5b65be0799a2d9422df21f
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=b28c72ba7c992bcd2f5b65be0799a2d9422df21f
Author: Jesse Gross <jesse at nicira.com>
		
datapath: Check vswitch_skb_checksum_setup() return code.
		
If vswitch_skb_checksum_setup() returns an error, the checksum
pointers probably haven't been set correctly which could cause
a crash later.  We should give up immediately on error.


commit a2377e444a0e0a3f3c6db2502c63cc9545572281
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a2377e444a0e0a3f3c6db2502c63cc9545572281
Author: Jesse Gross <jesse at nicira.com>
		
datapath: Call vswitch_skb_checksum_setup() before doing GSO.
		
Since GSO computes checksums as it does segmentation, we need to
setup the checksum pointers before calling skb_gso_segment().  Failing
to do so can potentially result in warnings, incorrect checksums,
crashes, or redundant checksum computation.  In general we don't
hit this case because the code path is run during the first packet
in a flow, which is generally not a large GSO packet.

This was found during the investigation of NIC-121 but has no impact
on it because vswitch_skb_checksum_setup() is a no-op on 2.6.27-based
XenServer kernels.


-----------------------------------------------------------------------

Summary of changes:
 datapath/actions.c   |    8 +++++++-
 datapath/datapath.c  |   11 ++++-------
 datapath/vport-gre.c |    4 +++-
 3 files changed, 14 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
Open vSwitch