[ovs-git] Open vSwitch: jsonrpc: Fix potential memory leak. (master)

dev at openvswitch.org dev at openvswitch.org
Wed Mar 24 23:54:43 UTC 2010

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  7c88a5dc3ac1a034552bb94d42394bd325c1204e (commit)
       via  c874f17fc743b38295f6059ab6554561b7555724 (commit)
       via  271915d3877ab9d74836a986cb2eb483071f048b (commit)
       via  9cb0788702e6187eafccabba0758095ced04552c (commit)
      from  5c43922c13983d2b5addf9e6dd3f54a006c568a6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7c88a5dc3ac1a034552bb94d42394bd325c1204e
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=7c88a5dc3ac1a034552bb94d42394bd325c1204e
Author: Ben Pfaff <blp at nicira.com>
jsonrpc: Fix potential memory leak.
This is unlikely to occur very often in practice, because s->stream
usually gets stuffed into s->rpc before long, but it is still a good idea
to fix it.

commit c874f17fc743b38295f6059ab6554561b7555724
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c874f17fc743b38295f6059ab6554561b7555724
Author: Ben Pfaff <blp at nicira.com>
fatal-signal: Initialize library upon any call to public function.
Not calling fatal_signal_init() means that the signal handlers don't get
registered, so the process won't clean up on fatal signals.  Furthermore,
signal_fds[0] is then 0, which means that fatal-signal_wait() waits on
stdin, so if you are testing a program interactively and accidentally type
something on stdin then that program's CPU usage jumps to 100%.

Since poll_block() calls fatal_signal_wait() this seems like the most
reliable solution.

commit 271915d3877ab9d74836a986cb2eb483071f048b
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=271915d3877ab9d74836a986cb2eb483071f048b
Author: Ben Pfaff <blp at nicira.com>
ovsdb: Fix ovsdb-server crash when specifying nonexistent file.
ovsdb_file_open__() can call (NULL) in its error exit
path, but ovsdb_schema_destroy() didn't tolerate a null pointer argument.

Bug #2538.

commit 9cb0788702e6187eafccabba0758095ced04552c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=9cb0788702e6187eafccabba0758095ced04552c
Author: Ben Pfaff <blp at nicira.com>
stream-ssl: Only re-read certificates and keys if they change.
Commit 415f6c0b1 "stream-ssl: Make no-op reconfiguration cheap" caused
ovsdb-server to re-read its certificates and keys every 60 seconds just
in case they changed.  However, doing this causes OpenSSL to drop its
connections.  This commit solves the problem by making stream-ssl re-read
certificates and keys only if the files changed.

Bug #2535.
Reported-by: Ram Jothikumar <rjothikumar at nicira.com>


Summary of changes:
 configure.ac       |    2 ++
 lib/fatal-signal.c |    6 +++++-
 lib/jsonrpc.c      |    1 +
 lib/stream-ssl.c   |   48 ++++++++++++++++++++++++++++++++++++++----------
 ovsdb/ovsdb.c      |    4 ++++
 5 files changed, 50 insertions(+), 11 deletions(-)

Open vSwitch

More information about the git mailing list