[ovs-git] Open vSwitch: sflow: Always add poller and sampler together. (master)

dev at openvswitch.org dev at openvswitch.org
Wed May 5 20:28:47 UTC 2010


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  5586445e9945574da85f96976ca650e19b8216c1 (commit)
       via  f9727d74050e1ff1c25ad0308a46e84c4d4870b5 (commit)
       via  c62caaa3f4132eba085c8ba15577b62195642711 (commit)
      from  e723ff43aab4f6d1c9a7198f7d2b226804800a9d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5586445e9945574da85f96976ca650e19b8216c1
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=5586445e9945574da85f96976ca650e19b8216c1
Author: Neil McKee <neil.mckee at inmon.com>
		
sflow: Always add poller and sampler together.
		
he ofproto_sflow_add_poller() and ofproto_sflow_add_sampler() calls
should always be made together, either when a port is added
dynamically with ofproto_sflow_add_port() or when the sflow_agent is
first created in ofproto_sflow_set_options().  I was seeing odd
behavior where either the pollers or the samplers would never be
instantiated depending on the order that things happened.  (It's OK to
add the same sampler or poller again, because the library routines
sfl_agent_addPoller() and sfl_agent_addSampler() will just return the
existing one if it is there.  Perhaps we should add a comment to make
that clear?).

I changed the parameters to ofproto_sflow_add_sampler to make it work
the same way as ofproto_sflow_add_poller, where the options are
extracted from os->options within the function itself.


commit f9727d74050e1ff1c25ad0308a46e84c4d4870b5
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=f9727d74050e1ff1c25ad0308a46e84c4d4870b5
Author: Neil McKee <neil.mckee at inmon.com>
		
sflow: Properly fill in initial destination VLAN in sFlow output.
		


commit c62caaa3f4132eba085c8ba15577b62195642711
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c62caaa3f4132eba085c8ba15577b62195642711
Author: Neil McKee <neil.mckee at inmon.com>
		
sflow: Include Ethernet FCS in frame_length to comply with sFlow spec.
		


-----------------------------------------------------------------------

Summary of changes:
 ofproto/ofproto-sflow.c |   25 +++++++++++++++----------
 1 files changed, 15 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
Open vSwitch




More information about the git mailing list