[ovs-git] Open vSwitch: ovsdb-client: Serialize columns in predictable order on "monitor" command. (master)

dev at openvswitch.org dev at openvswitch.org
Fri May 7 21:38:50 UTC 2010


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  a1ae5dc8da2d30704f7654e0d593cf2ca1e088f7 (commit)
       via  e86dd676cdb1885ee4f8f1fa92176d159d5bb533 (commit)
       via  1f4f3cd7e05f032ac3e39b877e1e72077ca985d5 (commit)
       via  62c87d4aed70d5085bbe1fec4d36c3c2d16c6a00 (commit)
       via  26adc8ddd75df99c17bf4bbe8dac5562213866bc (commit)
      from  f4267e344a9373a4efefff8f8f5b85f532d223e1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a1ae5dc8da2d30704f7654e0d593cf2ca1e088f7
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a1ae5dc8da2d30704f7654e0d593cf2ca1e088f7
Author: Ben Pfaff <blp at nicira.com>
		
ovsdb-client: Serialize columns in predictable order on "monitor" command.
		
The "monitor" command goes to some trouble to write its output in a
predictable order, so that test programs can reliably compare it against
expectations.  This commit fixes up one part that was missing, which is
that the columns were not being ordered predictably (it depended on
hash order, which differs between big-endian and little-endian systems).
It also updates the test suite to expect the new order.


commit e86dd676cdb1885ee4f8f1fa92176d159d5bb533
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e86dd676cdb1885ee4f8f1fa92176d159d5bb533
Author: Ben Pfaff <blp at nicira.com>
		
tests: Fix bug in "ovsdb-tool compact" test.
		
This test examines the OVSDB database log and checks that it contains what
it should for specified transactions.  However, the database log ordering
differs between big-endian and little-endian architectures because it is
written out in hash order.  We don't want to incur the expense of always
sorting the log as we write it out, so instead this commit fixes the
problem by sorting the log as it reads it, using the "test-json" program.


commit 1f4f3cd7e05f032ac3e39b877e1e72077ca985d5
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=1f4f3cd7e05f032ac3e39b877e1e72077ca985d5
Author: Ben Pfaff <blp at nicira.com>
		
tests: Fix bug in "weak references" test.
		
One part of the "weak references" test inserts invalid all-zeros weak
references into two columns and expects to get an error message mentioning
one of them.  Unfortunately the one that actually gets mentioned depends
on hash ordering and thus differs between big-endian and little-endian
machines.  This commit fixes the problem by only putting an invalid
reference in a single column, instead of two of them.


commit 62c87d4aed70d5085bbe1fec4d36c3c2d16c6a00
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=62c87d4aed70d5085bbe1fec4d36c3c2d16c6a00
Author: Ben Pfaff <blp at nicira.com>
		
tests: Fix bug in ovsdb-server test suite.
		
The formatting of OVSDB syntax errors differed between big-endian and
little-endian systems, which caused the "database multiplexing
implementation" test to fail on SPARC.  This commit fixes the problem by
always outputting JSON in syntax errors in deterministic (sorted) order.


commit 26adc8ddd75df99c17bf4bbe8dac5562213866bc
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=26adc8ddd75df99c17bf4bbe8dac5562213866bc
Author: Ben Pfaff <blp at nicira.com>
		
util: Fix GCC false-positive warning for CONTAINER_OF.
		
On sparc, GCC would issue the following warning for every use of
CONTAINER_OF:

    warning: cast increases required alignment of target type

This is a false positive: assuming that the data structure that it is
applied to was allocated properly, the use of CONTAINER_OF to reach it is
valid.  And if it was not allocated properly, then code that accesses it
other ways will have trouble too.


-----------------------------------------------------------------------

Summary of changes:
 lib/ovsdb-error.c        |    2 +-
 lib/util.h               |    2 +-
 ovsdb/ovsdb-client.c     |   18 +++++++++++++-----
 tests/ovsdb-execution.at |    3 ++-
 tests/ovsdb-monitor.at   |   12 ++++++------
 tests/ovsdb-server.at    |   40 ++++++++++++++++++++--------------------
 tests/ovsdb-tool.at      |   38 +++++++++++++++++++-------------------
 7 files changed, 62 insertions(+), 53 deletions(-)


hooks/post-receive
-- 
Open vSwitch




More information about the git mailing list