[ovs-git] Open vSwitch: vswitchd: Treat gratuitous ARP requests like gratuitous ARP replies. (master)

dev at openvswitch.org dev at openvswitch.org
Thu May 27 17:10:03 UTC 2010


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  5d0ae1387c968859b390dba9768ce44ac788405b (commit)
      from  208d496f15787e55777c2ef541595f9e750ef771 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5d0ae1387c968859b390dba9768ce44ac788405b
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=5d0ae1387c968859b390dba9768ce44ac788405b
Author: Ben Pfaff <blp at nicira.com>
		
vswitchd: Treat gratuitous ARP requests like gratuitous ARP replies.
		
vswitchd has long used a gratuitous ARP reply as an indication that a VM
has migrated, because traditional xen.org Linux DomUs send such packets out
when they complete migration.  Relatively recently, however, we realized
that upstream Linux does not do this.  Ian Campbell tracked this down to
two separate issues:

        1. A bug prevented gratuitous ARPs from being sent.

        2. When this was fixed, the gratuitous ARPs that were sent were
           requests, not replies, although kernel documentation sent that
           replies were to be sent.

Ian submitted patches to fix both bugs.  #1 is in process of revision for
acceptance.  #2 was rejected: according to Dave Miller, the documentation
is wrong, not the implementation, because ARP replies would unnecessarily
fill up the ARP tables of devices on the network.

OVS has not until now treated gratuitous ARP requests specially, only
replies.  Now that Linux will be using ARP requests to indicate migration,
OVS should also treat them as such.!  This commit does so.

See http://marc.info/?l=linux-netdev&m=127367215620212&w=2 for Ian's
original patch and http://marc.info/?l=linux-netdev&m=127468303701361&w=2
for Dave Miller's response.

CC: Ian Campbell <Ian.Campbell at citrix.com>
NIC-74.


-----------------------------------------------------------------------

Summary of changes:
 vswitchd/bridge.c |   15 ++++++++++-----
 1 files changed, 10 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
Open vSwitch




More information about the git mailing list