[ovs-git] Open vSwitch: ofproto: Improve comment in send_flow_removed(). (master)

dev at openvswitch.org dev at openvswitch.org
Fri Nov 5 16:32:58 UTC 2010


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  6d6c72594d019672f1fc45ba9ca95b622ac3e969 (commit)
       via  7a0efeb5ad32fc685640b3815da4e20a7f11e3c5 (commit)
       via  0bd0c6606aa8f8ecc3822faef9c34b4116791ac9 (commit)
       via  d48a591098fb9d6df9a6f41be511cbdb91905609 (commit)
       via  422bb884ec461dcbdff95013909812d0e36664ba (commit)
       via  217f48c61bbfe1422f00830f36d2d255d3622446 (commit)
       via  3a75cda939c7155ec9e12dd747983e37dee9b3e6 (commit)
       via  61d8d58305e7f9866a6d6c95c3a031c1bdece588 (commit)
       via  a23aab1fc2f66b63ba9b7e4b9c9a8f6d58c367d0 (commit)
       via  26c112c2419e95dcd6b5ceb3ca35e1fc790d2de4 (commit)
       via  71ce92352cbcb96f179f8ec19dd1e843d91d8828 (commit)
      from  7ef83faa29b5b8816d0bcd7913e026e33e31d87a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6d6c72594d019672f1fc45ba9ca95b622ac3e969
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=6d6c72594d019672f1fc45ba9ca95b622ac3e969
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Improve comment in send_flow_removed().
		


commit 7a0efeb5ad32fc685640b3815da4e20a7f11e3c5
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=7a0efeb5ad32fc685640b3815da4e20a7f11e3c5
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Simplify send_flow_removed().
		
I have no evidence that the optimization in this function is valuable.
An upcoming commit will introduce a new form of flow expiration message
that is sent to controllers that ask for it, while the standard OpenFlow
1.0 message is sent to other controllers.  Since retaining this
optimization with that logic would complicate the function, this commit
drops it.


commit 0bd0c6606aa8f8ecc3822faef9c34b4116791ac9
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=0bd0c6606aa8f8ecc3822faef9c34b4116791ac9
Author: Ben Pfaff <blp at nicira.com>
		
ofp-util: New functions make_nxmsg(), make_nxmsg_xid().
		
These functions slightly simplify constructing Nicira vendor extension
messages.


commit d48a591098fb9d6df9a6f41be511cbdb91905609
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=d48a591098fb9d6df9a6f41be511cbdb91905609
Author: Ben Pfaff <blp at nicira.com>
		
ofp-util: Add macros for composing error codes.
		
These are useful in static initializers and case labels, where function
calls are not allowed.


commit 422bb884ec461dcbdff95013909812d0e36664ba
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=422bb884ec461dcbdff95013909812d0e36664ba
Author: Ben Pfaff <blp at nicira.com>
		
Sync Nicira error number assignments with "wdp" branch.
		
This adds the error numbers that the "wdp" branch added, without adding
any uses of them (because they are not needed on "master" yet).


commit 217f48c61bbfe1422f00830f36d2d255d3622446
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=217f48c61bbfe1422f00830f36d2d255d3622446
Author: Ben Pfaff <blp at nicira.com>
		
ofp-util: Use our usual variable naming convention in make_ofp_error_msg().
		


commit 3a75cda939c7155ec9e12dd747983e37dee9b3e6
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=3a75cda939c7155ec9e12dd747983e37dee9b3e6
Author: Ben Pfaff <blp at nicira.com>
		
ofp-util: Actually map vendor codes to IDs correctly.
		
Reported-by: Justin Pettit <jpettit at nicira.com>


commit 61d8d58305e7f9866a6d6c95c3a031c1bdece588
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=61d8d58305e7f9866a6d6c95c3a031c1bdece588
Author: Ben Pfaff <blp at nicira.com>
		
ofp-util.h: Use NX_VENDOR_ID instead of literal numeric constant.
		


commit a23aab1fc2f66b63ba9b7e4b9c9a8f6d58c367d0
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a23aab1fc2f66b63ba9b7e4b9c9a8f6d58c367d0
Author: Ben Pfaff <blp at nicira.com>
		
Fix typos in comments.
		


commit 26c112c2419e95dcd6b5ceb3ca35e1fc790d2de4
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=26c112c2419e95dcd6b5ceb3ca35e1fc790d2de4
Author: Ben Pfaff <blp at nicira.com>
		
ofp-util: Add infrastructure for vendor extensions to OpenFlow error codes.
		
Cross-ported from "wdp" branch.


commit 71ce92352cbcb96f179f8ec19dd1e843d91d8828
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=71ce92352cbcb96f179f8ec19dd1e843d91d8828
Author: Ben Pfaff <blp at nicira.com>
		
ofp-util: Add more functions for supporting OpenFlow error codes.
		
Cross-ported from "wdp" branch.


-----------------------------------------------------------------------

Summary of changes:
 include/openflow/nicira-ext.h |   68 +++++++++++++++++++-
 lib/dpif.c                    |    7 ++-
 lib/ofp-util.c                |  113 +++++++++++++++++++++++++++++++++
 lib/ofp-util.h                |  139 ++++++++++++++++++++++++++++++++++++++++-
 ofproto/ofproto.c             |   69 ++++++--------------
 ofproto/status.c              |    6 +-
 utilities/ovs-ofctl.c         |   10 +--
 7 files changed, 348 insertions(+), 64 deletions(-)


hooks/post-receive
-- 
Open vSwitch




More information about the git mailing list