[ovs-git] Open vSwitch: ofproto: Avoid clearing NetFlow stats twice upon rule creation. (master)

dev at openvswitch.org dev at openvswitch.org
Thu Nov 11 19:29:22 UTC 2010


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  d6de72a12fad59941409ac3ff57f1660ac5a28bb (commit)
       via  1eb0942d2262a9cfce6793f519ea32da959d93b6 (commit)
       via  fa8b054f50e6f669a1cc4c41ada0f1fdad03e9dd (commit)
       via  0c43ad9a7501774ba33e55e8b5367e611ff0057f (commit)
       via  8050b31d635005a11e5f4ef5517af8672af7cf55 (commit)
       via  049c8dc2128f3d336c4b791bb34ec806ddac6b4b (commit)
       via  06da29ee250b9794c1d4377fb33b8bb65c52a47e (commit)
       via  1e37a2d75196c6e10ac078213ad94afb4f3e219a (commit)
       via  b6c9e612fa0801037c60339a931d29413e8fa08f (commit)
      from  9b2cfa734c35305abf29e6c64e94da47d4fc68db (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d6de72a12fad59941409ac3ff57f1660ac5a28bb
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=d6de72a12fad59941409ac3ff57f1660ac5a28bb
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Avoid clearing NetFlow stats twice upon rule creation.
		
This seems cleaner to me: it seems risky to "clear" something that has not
been initialized yet.  It's also a super-minor optimization, I suppose.


commit 1eb0942d2262a9cfce6793f519ea32da959d93b6
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=1eb0942d2262a9cfce6793f519ea32da959d93b6
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Make xlate_actions() initialize '*tags' itself.
		
This seems cleaner than expecting the caller to do it.


commit fa8b054f50e6f669a1cc4c41ada0f1fdad03e9dd
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=fa8b054f50e6f669a1cc4c41ada0f1fdad03e9dd
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Disable timeouts for flows added by ofproto_add_flow().
		
None of the existing callers of ofproto_add_flow() want an idle timeout,
but ofproto_add_flow() was giving them a 5-second timeout anyway.  I don't
know how this worked properly--in-band will patiently add the flow back
every few seconds anyway, but the bridge doesn't do that.

Also add an explanatory comment to ofproto_add_flow().


commit 0c43ad9a7501774ba33e55e8b5367e611ff0057f
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=0c43ad9a7501774ba33e55e8b5367e611ff0057f
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Fix used time of revalidated subrules.
		
Despite the comment, the 'used' member of a rule is always set to at least
the value of 'created', except in one case in revalidation.  That case
appears to be just a mistake, so this commit changes it and corrects the
comment.


commit 8050b31d635005a11e5f4ef5517af8672af7cf55
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=8050b31d635005a11e5f4ef5517af8672af7cf55
Author: Ben Pfaff <blp at nicira.com>
		
ofp-parse: Refactor flow parsing.
		


commit 049c8dc2128f3d336c4b791bb34ec806ddac6b4b
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=049c8dc2128f3d336c4b791bb34ec806ddac6b4b
Author: Ben Pfaff <blp at nicira.com>
		
ofp-parse: Generalize parse_ofp_add_flow_str() as parse_ofp_flow_mod_str().
		
This generalization allows us to delete several lines of code from
ovs-ofctl.c.


commit 06da29ee250b9794c1d4377fb33b8bb65c52a47e
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=06da29ee250b9794c1d4377fb33b8bb65c52a47e
Author: Ben Pfaff <blp at nicira.com>
		
nx-match: Add tests that wildcard bits are zeroed by flow parser.
		
Suggested-by: Justin Pettit <jpettit at nicira.com>


commit 1e37a2d75196c6e10ac078213ad94afb4f3e219a
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=1e37a2d75196c6e10ac078213ad94afb4f3e219a
Author: Ben Pfaff <blp at nicira.com>
		
Add support for matching Ethernet multicast frames.
		


commit b6c9e612fa0801037c60339a931d29413e8fa08f
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=b6c9e612fa0801037c60339a931d29413e8fa08f
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Implement support for registers in extended flow match.
		


-----------------------------------------------------------------------

Summary of changes:
 include/openflow/nicira-ext.h |  138 +++++++++++++++++-
 lib/classifier.c              |   34 ++++-
 lib/flow.c                    |   98 ++++++++++--
 lib/flow.h                    |   44 +++++-
 lib/nx-match.c                |  334 ++++++++++++++++++++++++++++++++++++++++-
 lib/nx-match.def              |   16 ++-
 lib/nx-match.h                |    9 +
 lib/odp-util.c                |    1 +
 lib/ofp-parse.c               |  322 ++++++++++++++++++++++------------------
 lib/ofp-parse.h               |   20 ++-
 lib/ofp-util.c                |   28 +++-
 ofproto/fail-open.c           |    2 +-
 ofproto/in-band.c             |    2 +-
 ofproto/netflow.c             |    8 +
 ofproto/netflow.h             |    1 +
 ofproto/ofproto.c             |   58 ++++++--
 ofproto/ofproto.h             |    3 +-
 tests/ovs-ofctl.at            |   26 +++-
 tests/test-classifier.c       |    3 +-
 utilities/ovs-ofctl.c         |   89 +++---------
 vswitchd/bridge.c             |    2 +-
 21 files changed, 954 insertions(+), 284 deletions(-)


hooks/post-receive
-- 
Open vSwitch




More information about the git mailing list