[ovs-git] Open vSwitch: coverage: Make the coverage counters catalog program-specific. (master)

dev at openvswitch.org dev at openvswitch.org
Tue Nov 30 18:45:33 UTC 2010


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  d76f09ea77e03ee5a3a7bb67bcab1ac4bb54172b (commit)
       via  f4e2e60be455af4d5bd294cfe19a7cb4ea13a9ff (commit)
       via  611d30ceb68c8542d11acee8248f66f9485505e9 (commit)
      from  847a0730a03f0fb4461c79ae957eabe03db71f53 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d76f09ea77e03ee5a3a7bb67bcab1ac4bb54172b
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=d76f09ea77e03ee5a3a7bb67bcab1ac4bb54172b
Author: Ben Pfaff <blp at nicira.com>
		
coverage: Make the coverage counters catalog program-specific.
		
Until now, the collection of coverage counters supported by a given OVS
program was not specific to that program.  That means that, for example,
even though ovs-dpctl does not have anything to do with mac_learning, it
still has a coverage counter for it.  This is confusing, at best.

This commit fixes the problem on some systems, in particular on ones that
use GCC and the GNU linker.  It uses the feature of the GNU linker
described in its manual as:

    If an orphaned section's name is representable as a C identifier then
    the linker will automatically see PROVIDE two symbols: __start_SECNAME
    and __end_SECNAME, where SECNAME is the name of the section.  These
    indicate the start address and end address of the orphaned section
    respectively.

Systems that don't support these features retain the earlier behavior.

This commit also fixes the annoyance that files that include coverage
counters must be listed on COVERAGE_FILES in lib/automake.mk.

This commit also fixes the annoyance that modifying any source file that
includes a coverage counter caused all programs that link against
libopenvswitch.a to relink, even programs that the source file was not
linked into.  For example, modifying ofproto/ofproto.c (which includes
coverage counters) caused tests/test-aes128 to relink, even though
test-aes128 does not link again ofproto.o.


commit f4e2e60be455af4d5bd294cfe19a7cb4ea13a9ff
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=f4e2e60be455af4d5bd294cfe19a7cb4ea13a9ff
Author: Ben Pfaff <blp at nicira.com>
		
netdev-linux: Remove counter double-increments.
		
A few coverage counters were incremented both in netdev generic code and
in netdev_linux code.  This commit drops the increments from the
lower-level code.

(This is not an actual bug because these counters are used only for
logging.)


commit 611d30ceb68c8542d11acee8248f66f9485505e9
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=611d30ceb68c8542d11acee8248f66f9485505e9
Author: Ben Pfaff <blp at nicira.com>
		
vlog: Generate vlog-modules.def automatically.
		


-----------------------------------------------------------------------

Summary of changes:
 Makefile.am                  |    1 +
 build-aux/check-vlog-modules |   66 ------------------------------
 lib/automake.mk              |   58 ++++++++++-----------------
 lib/coverage-counters.h      |   25 -----------
 lib/coverage-scan.pl         |   47 ---------------------
 lib/coverage.c               |   36 ++++++++++++----
 lib/coverage.h               |   38 ++++++++++-------
 lib/dpif.c                   |   13 ++++++
 lib/flow.c                   |    2 +
 lib/hmap.c                   |    5 ++
 lib/lockfile.c               |    5 ++
 lib/mac-learning.c           |    3 +
 lib/netdev-linux.c           |   11 ++++-
 lib/netdev.c                 |    5 ++
 lib/netlink.c                |    6 +++
 lib/poll-loop.c              |    3 +
 lib/process.c                |    5 ++
 lib/rconn.c                  |    5 ++
 lib/rtnetlink.c              |    2 +
 lib/stream-ssl.c             |    3 +
 lib/stream.c                 |    3 +
 lib/unixctl.c                |    3 +
 lib/util.c                   |    2 +
 lib/vconn.c                  |    4 ++
 lib/vlog-modules.def         |   92 ------------------------------------------
 m4/openvswitch.m4            |    4 +-
 ofproto/ofproto.c            |   31 ++++++++++++++
 ofproto/pktbuf.c             |    5 ++
 vswitchd/bridge.c            |    4 ++
 29 files changed, 191 insertions(+), 296 deletions(-)
 delete mode 100755 build-aux/check-vlog-modules
 delete mode 100644 lib/coverage-counters.h
 delete mode 100755 lib/coverage-scan.pl
 delete mode 100644 lib/vlog-modules.def


hooks/post-receive
-- 
Open vSwitch




More information about the git mailing list