[ovs-git] Open vSwitch: netflow: Avoid (theoretically) looping 2**32 times. (master)

dev at openvswitch.org dev at openvswitch.org
Fri Oct 1 21:32:55 UTC 2010


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  9ebc44ae8c5940513a8dcc2aab8dcca8aff9d2a2 (commit)
       via  48f846e66ef06c39228fb1d3f8d8bfd1c695c93d (commit)
      from  8b055d92533271b05843f4b62fa98aba5e7ce90a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9ebc44ae8c5940513a8dcc2aab8dcca8aff9d2a2
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=9ebc44ae8c5940513a8dcc2aab8dcca8aff9d2a2
Author: Ben Pfaff <blp at nicira.com>
		
netflow: Avoid (theoretically) looping 2**32 times.
		
If the netflow byte counter is UINT64_MAX, or at any rate much larger than
UINT32_MAX, netflow_expire() could loop for a very long time.  This commit
avoids that case.

This is only a theoretical bug fix.  I don't know of any actual bug that
would cause a counter to be that high.


commit 48f846e66ef06c39228fb1d3f8d8bfd1c695c93d
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=48f846e66ef06c39228fb1d3f8d8bfd1c695c93d
Author: Ben Pfaff <blp at nicira.com>
		
netflow: Do 64-bit division less often.
		
64-bit division is expensive.  Usually we can avoid it entirely, as done by
this patch.


-----------------------------------------------------------------------

Summary of changes:
 ofproto/netflow.c |   46 ++++++++++++++++++++++++++++++++--------------
 1 files changed, 32 insertions(+), 14 deletions(-)


hooks/post-receive
-- 
Open vSwitch




More information about the git mailing list