[ovs-git] Open vSwitch: ofproto: Group functions related to flow expiration together. (master)

dev at openvswitch.org dev at openvswitch.org
Wed Oct 6 21:44:40 UTC 2010


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  4a4cdb3b24f582e6a751a7a67bf4cbdbd071fcf6 (commit)
       via  3dffcf0701f7e7753710348d34eb5be007525877 (commit)
      from  b8dcf5e9c554e2c5fc35a68a086d304fc0cea59a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4a4cdb3b24f582e6a751a7a67bf4cbdbd071fcf6
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=4a4cdb3b24f582e6a751a7a67bf4cbdbd071fcf6
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Group functions related to flow expiration together.
		
This should be a purely stylistic change, with no effect on behavior.

This commit changes the callback pointer passed to the
classifier_for_each() from a pointer to an ofproto to a pointer to a
structure that includes an ofproto.  Future commits planned will add
more members to this new structure.


commit 3dffcf0701f7e7753710348d34eb5be007525877
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=3dffcf0701f7e7753710348d34eb5be007525877
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Avoid wasting memory malloc()'ing empty action sets for subrules.
		
GNU libc treats malloc(0) as malloc(1).  Subrules always have an n_actions
of 0, so this code was wasting time and memory for subrules.  This commit
stops doing that.

Also audits and fixes some very pedantic potential problems with null
pointers; e.g. the C standard says that NULL may not be compared with the
< operator, even if both arguments are null, and it also says that a null
pointer may not be passed to memcpy() or memcmp(), even if the length is
zero.


-----------------------------------------------------------------------

Summary of changes:
 lib/ofp-util.c    |    9 +-
 ofproto/ofproto.c |  338 ++++++++++++++++++++++++++++++-----------------------
 2 files changed, 194 insertions(+), 153 deletions(-)


hooks/post-receive
-- 
Open vSwitch




More information about the git mailing list