[ovs-git] Open vSwitch: classifier: Introduce macros for iterating exact-match flows. (master)

dev at openvswitch.org dev at openvswitch.org
Thu Oct 7 17:57:53 UTC 2010


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  35950f0cfa75821e4db5fc767b5a1671c40c6b1a (commit)
       via  da89bf9eb715a779752462f523ab567ea3916fa9 (commit)
       via  8497dd41214ddaac26928f2efa90becd1b336a52 (commit)
       via  431d470740d6c8ad4fea738821729096c3e0faf4 (commit)
       via  3b5876160405679bac9ff6832b6a36971e65afa2 (commit)
      from  4a4cdb3b24f582e6a751a7a67bf4cbdbd071fcf6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 35950f0cfa75821e4db5fc767b5a1671c40c6b1a
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=35950f0cfa75821e4db5fc767b5a1671c40c6b1a
Author: Ben Pfaff <blp at nicira.com>
		
classifier: Introduce macros for iterating exact-match flows.
		
This special case of iterating through flows is easier and presumably
faster to implement using a macro.


commit da89bf9eb715a779752462f523ab567ea3916fa9
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=da89bf9eb715a779752462f523ab567ea3916fa9
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Iterate through exact-match rules first during expiration.
		
A wildcarded flow is idle only if all of its subrules have expired because
they were idle, so unless we expire exact-match rules first it is possible
that a wildcarded flow fails to expire as soon as it should.

(The current implementation of classifier_for_each() iterates through
exact-match rules before wildcarded rules, but nothing in the interface
guarantees that.)


commit 8497dd41214ddaac26928f2efa90becd1b336a52
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=8497dd41214ddaac26928f2efa90becd1b336a52
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Drop unneeded poll_immediate_wake().
		
This poll_immediate_wake() is unnecessary because netflow_run() is always
called afterward within the same poll loop.  It's better to delete it, to
avoid wasting CPU.


commit 431d470740d6c8ad4fea738821729096c3e0faf4
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=431d470740d6c8ad4fea738821729096c3e0faf4
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Fix effective memory leak for uninstallable flows.
		
In one or two corner cases, flows cannot be installed because every packet
in the flow must be processed by userspace.  The code to expire rules was
ignoring these uninstallable rules, and thus they would never get freed,
even after they became idle.  This commit fixes the problem.


commit 3b5876160405679bac9ff6832b6a36971e65afa2
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=3b5876160405679bac9ff6832b6a36971e65afa2
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Factor conditional out of loop in send_flow_removed().
		


-----------------------------------------------------------------------

Summary of changes:
 lib/classifier.c  |    5 +++-
 lib/classifier.h  |    6 ++++
 ofproto/ofproto.c |   79 +++++++++++++++++++++++++++++++++++------------------
 3 files changed, 62 insertions(+), 28 deletions(-)


hooks/post-receive
-- 
Open vSwitch




More information about the git mailing list