[ovs-git] Open vSwitch: netflow: Back-out optimization that could lead to infinite loop (master)

dev at openvswitch.org dev at openvswitch.org
Tue Oct 12 18:42:27 UTC 2010


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  c06955bc63bf504fc6fa87fd9780993bc45cad09 (commit)
      from  f1670a487adf5d5352eaf32f15bcf2958cdb1771 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c06955bc63bf504fc6fa87fd9780993bc45cad09
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c06955bc63bf504fc6fa87fd9780993bc45cad09
Author: Justin Pettit <jpettit at nicira.com>
		
netflow: Back-out optimization that could lead to infinite loop
		
Commit 924282 (netflow: Do 64-bit division less often.) attempted to
remove the 64-bit division used to break flow records with large byte
counts into multiple NetFlow records.  The calculation to determine the
number of records was incorrect and should have shifted "byte_delta" by
31 instead of 32.  This commit reverts the change (while keeping commit
f22a24 (netflow: Avoid (theoretically) looping 2**32 times.) ), since
the logic is more straight-forward than the optimized version.

Bug #3813


-----------------------------------------------------------------------

Summary of changes:
 ofproto/netflow.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
Open vSwitch




More information about the git mailing list