[ovs-git] Open vSwitch: netflow: Back-out optimization that could lead to infinite loop (lts-1.0)

dev at openvswitch.org dev at openvswitch.org
Tue Oct 12 18:58:30 UTC 2010


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, lts-1.0 has been updated
       via  f3dbabf1342a15e86c9806fae850ce446438b284 (commit)
      from  0dfae8613ef3e5dc9bae8fa2a671510d5752b3b1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f3dbabf1342a15e86c9806fae850ce446438b284
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=f3dbabf1342a15e86c9806fae850ce446438b284
Author: Justin Pettit <jpettit at nicira.com>
		
netflow: Back-out optimization that could lead to infinite loop
		
Commit 924282 (netflow: Do 64-bit division less often.) attempted to
remove the 64-bit division used to break flow records with large byte
counts into multiple NetFlow records.  The calculation to determine the
number of records was incorrect and should have shifted "byte_delta" by
31 instead of 32.  This commit reverts the change (while keeping commit
f22a24 (netflow: Avoid (theoretically) looping 2**32 times.) ), since
the logic is more straight-forward than the optimized version.

Bug #3813


-----------------------------------------------------------------------

Summary of changes:
 ofproto/netflow.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
Open vSwitch




More information about the git mailing list