[ovs-git] Open vSwitch: classifier: Change classifier_rule_overlaps() to take a cls_rule *. (master)

dev at openvswitch.org dev at openvswitch.org
Fri Oct 29 16:59:22 UTC 2010


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  faa50f408b92163e21e19d69589728d5c0ebcb70 (commit)
       via  76ecc721793b29c8bae44b10a065ec9ac07a9e4b (commit)
       via  48c3de13bee26106d8e708600904f2b20bd08818 (commit)
       via  fbb2ea0b5bebaae691ce6ac4b3a2eed65c775d9b (commit)
       via  e65dc5c57e4520d838350607d256f251e4d81235 (commit)
       via  7da6be985c6fc7f6b425f660501133f1118a73b5 (commit)
       via  386a62a104613a06214104e364f453522bdad6c9 (commit)
       via  494e43a517694cff1ca6304f6456ba0edbb924e2 (commit)
       via  c2bb4851cb6401b764081cd36c1cf6624c5c4c00 (commit)
       via  5436300437bd20c5e8e006fedc55c517cb090de5 (commit)
       via  8054fc48f9a620aa07714a70f6ec301e0d8ec4ee (commit)
       via  0b3e77bbef23a41d45a3a29ba32eb55759878f03 (commit)
       via  fba473391b92b6f2ce33a0acd68920941cb47b03 (commit)
       via  d98e60075528c3065ad453f7add4b30f22edcde3 (commit)
       via  10a24935c9d382e4d85b05d9616843f3d3bb4983 (commit)
       via  965f03d85ff6288eec3919edb67d5a2d247a6625 (commit)
       via  6c2e425edffa52e126c6599a15b5a703312bd6e8 (commit)
       via  700712e226b325f02421189f6fb52bff167876ce (commit)
      from  85da620e9788b473797b95212b916327974e6942 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit faa50f408b92163e21e19d69589728d5c0ebcb70
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=faa50f408b92163e21e19d69589728d5c0ebcb70
Author: Ben Pfaff <blp at nicira.com>
		
classifier: Change classifier_rule_overlaps() to take a cls_rule *.
		
There's no benefit to spelling out all of the components of a cls_rule
separately.  Just use cls_rule itself.


commit 76ecc721793b29c8bae44b10a065ec9ac07a9e4b
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=76ecc721793b29c8bae44b10a065ec9ac07a9e4b
Author: Ben Pfaff <blp at nicira.com>
		
classifier: Change classifier_find_rule_exactly() to take a cls_rule *.
		
There's no benefit to spelling out all of the components of a cls_rule
separately.  Just use cls_rule itself.


commit 48c3de13bee26106d8e708600904f2b20bd08818
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=48c3de13bee26106d8e708600904f2b20bd08818
Author: Ben Pfaff <blp at nicira.com>
		
classifier: Merge classifier_lookup_wild(), classifier_lookup_exact().
		
Merge these functions into classifier_lookup() and update its interface.

The new version of the classifier soon to be implemented naturally merges
these functions, so this commit updates the interface early.


commit fbb2ea0b5bebaae691ce6ac4b3a2eed65c775d9b
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=fbb2ea0b5bebaae691ce6ac4b3a2eed65c775d9b
Author: Ben Pfaff <blp at nicira.com>
		
classifier: Remove classifier_insert_exact().
		
This function doesn't provide any extra useful functionality.  It is
amenable to a slightly optimized implementation in the current classifier,
but not in the one that will soon replace it, so get rid of it.


commit e65dc5c57e4520d838350607d256f251e4d81235
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e65dc5c57e4520d838350607d256f251e4d81235
Author: Ben Pfaff <blp at nicira.com>
		
classifier: Remove unused functions cls_rule_moved(), cls_rule_replace().
		
In preparation for rewriting the classifier, remove some functions that
nothing uses and have no tests.


commit 7da6be985c6fc7f6b425f660501133f1118a73b5
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=7da6be985c6fc7f6b425f660501133f1118a73b5
Author: Ben Pfaff <blp at nicira.com>
		
odp-util: Print in_port in decimal in format_odp_flow_key().
		
Suggested-by: Justin Pettit <jpettit at nicira.com>


commit 386a62a104613a06214104e364f453522bdad6c9
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=386a62a104613a06214104e364f453522bdad6c9
Author: Ben Pfaff <blp at nicira.com>
		
odp-util: Print tunnel id as part of ODP flow key in format_odp_flow_key().
		


commit 494e43a517694cff1ca6304f6456ba0edbb924e2
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=494e43a517694cff1ca6304f6456ba0edbb924e2
Author: Ben Pfaff <blp at nicira.com>
		
flow: Add more functions for working with flow_wildcards.
		
These have limited use now but will become more important later.


commit c2bb4851cb6401b764081cd36c1cf6624c5c4c00
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c2bb4851cb6401b764081cd36c1cf6624c5c4c00
Author: Ben Pfaff <blp at nicira.com>
		
flow: Use vlan_tci_to_pcp() helper.
		
This is just a small cleanup that should not change any behavior.


commit 5436300437bd20c5e8e006fedc55c517cb090de5
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=5436300437bd20c5e8e006fedc55c517cb090de5
Author: Ben Pfaff <blp at nicira.com>
		
flow: Un-inline flow_wildcards functions.
		
These functions really seem too big to inline.


commit 8054fc48f9a620aa07714a70f6ec301e0d8ec4ee
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=8054fc48f9a620aa07714a70f6ec301e0d8ec4ee
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Use ovs_be<N> types in appropriate places.
		
There are many more places in OVS where using these types would be an
improvement, but the ofproto code is extra confusing because it uses
a mix of byte orders.


commit 0b3e77bbef23a41d45a3a29ba32eb55759878f03
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=0b3e77bbef23a41d45a3a29ba32eb55759878f03
Author: Ben Pfaff <blp at nicira.com>
		
flow: Use ovs_be<N> types in appropriate places.
		
There are many more places in OVS where using these types would be an
improvement, but the flow code is particularly confusing because it uses
a mix of byte orders.


commit fba473391b92b6f2ce33a0acd68920941cb47b03
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=fba473391b92b6f2ce33a0acd68920941cb47b03
Author: Ben Pfaff <blp at nicira.com>
		
Make the ovs_be<N> types generally available.
		
Using these types for data in network byte order makes code clearer, and
allows the "sparse" checker to give warnings for misuse.


commit d98e60075528c3065ad453f7add4b30f22edcde3
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=d98e60075528c3065ad453f7add4b30f22edcde3
Author: Ben Pfaff <blp at nicira.com>
		
vlog: Make client supply semicolon for VLOG_DEFINE_THIS_MODULE.
		
It's kind of odd for VLOG_DEFINE_THIS_MODULE to supply its own semicolon,
so this commit switches to the more common form.


commit 10a24935c9d382e4d85b05d9616843f3d3bb4983
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=10a24935c9d382e4d85b05d9616843f3d3bb4983
Author: Ben Pfaff <blp at nicira.com>
		
xtoxll: Rename "byte-order" since it now include more than xtoxll.
		
Suggested-by: Justin Pettit <jpettit at nicira.com>


commit 965f03d85ff6288eec3919edb67d5a2d247a6625
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=965f03d85ff6288eec3919edb67d5a2d247a6625
Author: Ben Pfaff <blp at nicira.com>
		
xtoxll: Add byte conversions macros for use in constant expressions.
		


commit 6c2e425edffa52e126c6599a15b5a703312bd6e8
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=6c2e425edffa52e126c6599a15b5a703312bd6e8
Author: Ben Pfaff <blp at nicira.com>
		
hmap: New macro HMAP_NODE_NULL_INITIALIZER.
		


commit 700712e226b325f02421189f6fb52bff167876ce
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=700712e226b325f02421189f6fb52bff167876ce
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Fix memory leak in handle_packet_out().
		


-----------------------------------------------------------------------

Summary of changes:
 build-aux/check-structs                        |    3 +
 build-aux/check-vlog-modules                   |    2 +-
 include/openvswitch/datapath-protocol.h        |    5 +-
 lib/backtrace.h => include/openvswitch/types.h |   28 +++--
 lib/automake.mk                                |    4 +-
 lib/backtrace.c                                |    2 +-
 lib/byte-order.h                               |   62 ++++++++++
 lib/classifier.c                               |  155 ++++++++----------------
 lib/classifier.h                               |   29 ++---
 lib/coverage.c                                 |    2 +-
 lib/daemon.c                                   |    2 +-
 lib/dhcp-client.c                              |    2 +-
 lib/dhcp.c                                     |    2 +-
 lib/dpif-linux.c                               |    2 +-
 lib/dpif-netdev.c                              |    2 +-
 lib/dpif.c                                     |    2 +-
 lib/entropy.c                                  |    2 +-
 lib/fatal-signal.c                             |    2 +-
 lib/flow.c                                     |  113 +++++++++++++++---
 lib/flow.h                                     |   54 +++------
 lib/hmap.h                                     |    1 +
 lib/jsonrpc.c                                  |    2 +-
 lib/leak-checker.c                             |    2 +-
 lib/learning-switch.c                          |    4 +-
 lib/lockfile.c                                 |    2 +-
 lib/mac-learning.c                             |    2 +-
 lib/netdev-linux.c                             |    2 +-
 lib/netdev-vport.c                             |    2 +-
 lib/netdev.c                                   |    2 +-
 lib/netlink.c                                  |    2 +-
 lib/odp-util.c                                 |    3 +-
 lib/ofp-parse.c                                |    4 +-
 lib/ofp-print.c                                |    2 +-
 lib/ofp-util.c                                 |    4 +-
 lib/ovsdb-error.c                              |    2 +-
 lib/ovsdb-idl.c                                |    2 +-
 lib/pcap.c                                     |    2 +-
 lib/poll-loop.c                                |    2 +-
 lib/process.c                                  |    2 +-
 lib/rconn.c                                    |    2 +-
 lib/reconnect.c                                |    2 +-
 lib/rtnetlink.c                                |    2 +-
 lib/socket-util.c                              |    2 +-
 lib/stream-fd.c                                |    2 +-
 lib/stream-ssl.c                               |    2 +-
 lib/stream-tcp.c                               |    2 +-
 lib/stream-unix.c                              |    2 +-
 lib/stream.c                                   |    2 +-
 lib/svec.c                                     |    2 +-
 lib/timeval.c                                  |    2 +-
 lib/unaligned.h                                |    2 +-
 lib/unixctl.c                                  |    2 +-
 lib/util.c                                     |    2 +-
 lib/vconn-stream.c                             |    2 +-
 lib/vconn.c                                    |    2 +-
 lib/vlog.c                                     |    2 +-
 lib/vlog.h                                     |    8 +-
 lib/xtoxll.h                                   |   34 -----
 ofproto/collectors.c                           |    2 +-
 ofproto/discovery.c                            |    2 +-
 ofproto/fail-open.c                            |    2 +-
 ofproto/in-band.c                              |    2 +-
 ofproto/netflow.c                              |    4 +-
 ofproto/ofproto-sflow.c                        |    2 +-
 ofproto/ofproto.c                              |   77 ++++++------
 ofproto/pktbuf.c                               |    2 +-
 ofproto/status.c                               |    2 +-
 ovsdb/file.c                                   |    2 +-
 ovsdb/jsonrpc-server.c                         |    2 +-
 ovsdb/log.c                                    |    2 +-
 ovsdb/ovsdb-client.c                           |    2 +-
 ovsdb/ovsdb-server.c                           |    2 +-
 ovsdb/ovsdb-tool.c                             |    2 +-
 tests/automake.mk                              |    6 +
 tests/library.at                               |    5 +
 tests/test-byte-order.c                        |   49 ++++++++
 tests/test-classifier.c                        |   57 ++-------
 utilities/ovs-controller.c                     |    2 +-
 utilities/ovs-discover.c                       |    2 +-
 utilities/ovs-dpctl.c                          |    2 +-
 utilities/ovs-ofctl.c                          |    4 +-
 utilities/ovs-openflowd.c                      |    2 +-
 utilities/ovs-vsctl.c                          |    2 +-
 vswitchd/bridge.c                              |    4 +-
 vswitchd/ovs-brcompatd.c                       |    2 +-
 vswitchd/ovs-vswitchd.c                        |    2 +-
 vswitchd/proc-net-compat.c                     |    2 +-
 vswitchd/system-stats.c                        |    2 +-
 vswitchd/xenserver.c                           |    2 +-
 89 files changed, 456 insertions(+), 391 deletions(-)
 copy lib/backtrace.h => include/openvswitch/types.h (52%)
 create mode 100644 lib/byte-order.h
 delete mode 100644 lib/xtoxll.h
 create mode 100644 tests/test-byte-order.c


hooks/post-receive
-- 
Open vSwitch




More information about the git mailing list