[ovs-git] Open vSwitch: ovsdb-idl: Suppress "delete" operations for garbage-collected tables. (master)

[dev at openvswitch.org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  dcd1dbc5b3088b1729238be752e75e89cbe1fa27 (commit)
      from  f8064ac96e4aa1600861f1d76ab424e0425ba429 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit dcd1dbc5b3088b1729238be752e75e89cbe1fa27
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=dcd1dbc5b3088b1729238be752e75e89cbe1fa27
Author: Ben Pfaff <blp at nicira.com>
		
ovsdb-idl: Suppress "delete" operations for garbage-collected tables.
		
Deciding what delete operations to issue on garbage-collected tables has
been a bit of a difficult issue for ovs-vsctl.  When garbage collection was
introduced in commit c5f341a "ovsdb: Implement garbage collection",
ovs-vsctl did not issue any deletions for these tables at all.  As a side
effect, ovs-vsctl did not notice that records were going to be deleted.
That meant that when multiple commands were issued in one ovs-vsctl run,
ovs-vsctl could get confused by apparent duplicate records that did not
in fact exist.  Commit 28a14bf "ovs-vsctl: Back out garbage collection
changes" fixed the problem by putting all of the explicit deletions back
into ovs-vsctl.

However, adding these explicit deletions had the price that it then became
(again) impossible to use ovs-vsctl commands to delete duplicates, for
example to use "ovs-vsctl del-br" to delete a bridge that points to the
same Port records that some other Bridge record also does.  This commit
makes that possible again, by implementing a compromise:

    * Internally, ovs-vsctl deletes the records that it believes should be
      deleted.

    * ovsdb-idl suppresses the deletions when it makes the RPC call into
      the database server.

Bug #5358.
Reported-by: Henrik Amren <henrik at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/ovsdb-idl.c          |   16 ++++++++++------
 utilities/ovs-vsctl.8.in |   13 +++++++------
 2 files changed, 17 insertions(+), 12 deletions(-)


hooks/post-receive
-- 
Open vSwitch