[ovs-git] Open vSwitch: in-band: Delete remaining rules when disabling in-band control. (master)

dev at openvswitch.org dev at openvswitch.org
Thu Aug 4 03:52:16 UTC 2011

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  6da1e8091eb2e19de7ba5e0c73ac3e7dd437743d (commit)
       via  2bd5b8145b7cf1851d51e258ab614414f2496aae (commit)
      from  3e60856b5427647da2c6300e3c0740c7f8977e54 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6da1e8091eb2e19de7ba5e0c73ac3e7dd437743d
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=6da1e8091eb2e19de7ba5e0c73ac3e7dd437743d
Author: Ben Pfaff <blp at nicira.com>
in-band: Delete remaining rules when disabling in-band control.
in_band_destroy() doesn't remove all of the rules that in-band control
adds (and it cannot, because that might require waiting for an existing
asynchronous flow modification or addition to complete), so turning on
other-config:disable-in-band or deleting all of the OpenFlow controllers
did not delete all of the in-band rules.

This commit fixes the problem by making the in-band control object hang
around until all of the flows that it set up have actually been deleted.

This problem was introduced as part of commit 7ee20df "ofproto: Implement
asynchronous OFPT_FLOW_MOD commands."

Reported-by: Brad Hall <brad at nicira.com>

commit 2bd5b8145b7cf1851d51e258ab614414f2496aae
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=2bd5b8145b7cf1851d51e258ab614414f2496aae
Author: Ben Pfaff <blp at nicira.com>
connmgr: Drop 'next_in_band_update' timer.
This timer used to exist because it was possible for in-band remote IP
addresses to change without any intentional configuration change in one
case: where controller discovery found a new controller.  Controller
discovery was removed long ago, but the reason for the timer had been
forgotten and so remained.  This commit removes it.


Summary of changes:
 ofproto/connmgr.c |   20 ++++++++------------
 ofproto/in-band.c |   11 +++++++++--
 ofproto/in-band.h |    2 +-
 3 files changed, 18 insertions(+), 15 deletions(-)

Open vSwitch

More information about the git mailing list