[ovs-git] Open vSwitch: socket-util: Correctly return negative values for errors. (branch-1.2)

dev at openvswitch.org dev at openvswitch.org
Wed Dec 7 16:42:21 UTC 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.2 has been updated
       via  2a71b8db7d120fbf22aa8f39c64a6fed1f5188ed (commit)
      from  65038bdcb2450307b72a57afe32914098e7ab12b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2a71b8db7d120fbf22aa8f39c64a6fed1f5188ed
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=2a71b8db7d120fbf22aa8f39c64a6fed1f5188ed
Author: Ben Pfaff <blp at nicira.com>
		
socket-util: Correctly return negative values for errors.
		
The comment on this function says that negative values indicate errors, and
the callers assume that too, but in fact it was returning positive errno
values, which are indistinguishable from valid fd numbers.

It really seems to me that this should have been found pretty quickly in
the field, since stream-tcp and stream-ssl both use inet_open_passive to
implement their passive listeners.  I'm surprised that no one has reported
it.


-----------------------------------------------------------------------

Summary of changes:
 lib/socket-util.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list