[ovs-git] Open vSwitch: datapath: Dump flow actions only if there is room. (master)

dev at openvswitch.org dev at openvswitch.org
Tue Feb 1 17:25:35 UTC 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  3005302426764a2f701bb3507ad9602e3fe2dbb9 (commit)
      from  0700107651b6a774f8f7ba873259a5d5011e3cb0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3005302426764a2f701bb3507ad9602e3fe2dbb9
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=3005302426764a2f701bb3507ad9602e3fe2dbb9
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Dump flow actions only if there is room.
		
Expanding an skbuff in a netlink dump handler doesn't work well.  We
weren't updating the truesize of the skb or the allocation within the
socket that netlink_dump() had put the skb in.  The code had other bugs
too.

This commit fixes the problem (in my tests, anyway) by avoiding expanding
the reply skbuff to fill in the actions.  Instead, in such a case the
userspace client has to do a separate "get" action to get the actions.
This commit also updates userspace to do this automatically for dumps in
the cases where the caller cares (only "ovs-dpctl dump-flows" currently
cares).

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>
Bug #4520.


-----------------------------------------------------------------------

Summary of changes:
 datapath/datapath.c |   32 +++++++++------------
 lib/dpif-linux.c    |   74 ++++++++++++++++++++++++++++++++++++--------------
 2 files changed, 67 insertions(+), 39 deletions(-)


hooks/post-receive
-- 
Open vSwitch




More information about the git mailing list