[ovs-git] Open vSwitch: daemon: Suppress valgrind warnings from read_pidfile(). (master)

dev at openvswitch.org dev at openvswitch.org
Thu Feb 3 22:56:51 UTC 2011

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  e7668254f2f8f7208905c858ffbc84a65bb13815 (commit)
       via  535d6987a7af3bef33bf2db21b52bb81e3ea64ee (commit)
      from  87824b0bfa2daf4a1b1949a96feaeb0d5710fb38 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e7668254f2f8f7208905c858ffbc84a65bb13815
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e7668254f2f8f7208905c858ffbc84a65bb13815
Author: Ben Pfaff <blp at nicira.com>
daemon: Suppress valgrind warnings from read_pidfile().
The version of valgrind I have in my test VMs doesn't know what F_GETLK
does, so it complains that l_pid is uninitialized even though fcntl sets
it.  Initializing it ourselves before calling the function avoids a series
of false-positive warnings about use of uninitialized data.

commit 535d6987a7af3bef33bf2db21b52bb81e3ea64ee
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=535d6987a7af3bef33bf2db21b52bb81e3ea64ee
Author: Ben Pfaff <blp at nicira.com>
Zero padding bytes in odp_key_ipv4, odp_key_arp.
This is a potential security issue for the kernel.  In userspace it just
provokes false-positive valgrind warnings (which is how I found it).

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


Summary of changes:
 datapath/flow.c |    3 +++
 lib/daemon.c    |    3 ++-
 lib/odp-util.c  |    3 +++
 3 files changed, 8 insertions(+), 1 deletions(-)

Open vSwitch

More information about the git mailing list