[ovs-git] Open vSwitch: datapath: Better calculate max nlattr-formatted flow size. (master)

dev at openvswitch.org dev at openvswitch.org
Mon Feb 7 23:42:07 UTC 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  18c43631587c68bcd8ce82fcdd6b27ed3d998071 (commit)
       via  7d332293f8f8d3faa50ba6faf415af864d32b686 (commit)
      from  a4a2643672e4d2f68f8246e406749009a3f3211b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 18c43631587c68bcd8ce82fcdd6b27ed3d998071
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=18c43631587c68bcd8ce82fcdd6b27ed3d998071
Author: Justin Pettit <jpettit at nicira.com>
		
datapath: Better calculate max nlattr-formatted flow size.
		
Both userspace and the kernel allocate space based on the max size of a
nlattr-formatted flow.  It was easy to change the max size of a flow
definition and cause crashes by forgetting to update one or both of
those definitions.  This commit attempts to make that harder by
providing a better description of how the max size is calculated and a
build check to look for a common indication that it may have changed.

Signed-off-by: Justin Pettit <jpettit at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


commit 7d332293f8f8d3faa50ba6faf415af864d32b686
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=7d332293f8f8d3faa50ba6faf415af864d32b686
Author: Justin Pettit <jpettit at nicira.com>
		
datapath: Increase size of max nlattr-formatted flow to 132.
		
The addition of IPv6 matching increased the maximum size of a
nlattr-formatted flow.  This was not properly reflected in the userspace
and kernel #defines that reserve space for the flows and could lead to
crashes.  This commit increases the size uniformly to 132 bytes.

Signed-off-by: Justin Pettit <jpettit at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 datapath/flow.c |    5 +++++
 datapath/flow.h |   19 ++++++++++++++++---
 lib/odp-util.h  |   27 +++++++++++++++++++++++----
 3 files changed, 44 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
Open vSwitch




More information about the git mailing list