[ovs-git] Open vSwitch: multipath: Validate multipath actions more thoroughly in multipath_parse(). (master)

dev at openvswitch.org dev at openvswitch.org
Wed Feb 23 18:05:16 UTC 2011

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  770f1f66bb9dc4e784e6c2c5351089c62b9a5919 (commit)
       via  c4894ed48f0c727a87fc64629623bd62aef1e95b (commit)
       via  338bd6a0fe317e6a320aca67a1dc2d090ef77de9 (commit)
      from  40a09c8aa9577d0d099eb5bbcb5ef69800e9e6f0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 770f1f66bb9dc4e784e6c2c5351089c62b9a5919
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=770f1f66bb9dc4e784e6c2c5351089c62b9a5919
Author: Ben Pfaff <blp at nicira.com>
multipath: Validate multipath actions more thoroughly in multipath_parse().
The stricter validation requires updates to the calls to test-multipath
to supply a valid n_links value.  test-multipath doesn't actually use
that value (it runs over different values in an internal "for" loop), so
this doesn't change any behavior.

Also adds a test to exercise each possible multipath_parse() error message.

Reported-by: Reid Price <reid at nicira.com>
Bug #4462.

commit c4894ed48f0c727a87fc64629623bd62aef1e95b
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c4894ed48f0c727a87fc64629623bd62aef1e95b
Author: Ben Pfaff <blp at nicira.com>
ofp-parse: Don't segfault when an OpenFlow action's argument is missing.
Some actions checked that 'arg' was nonnull before attempting to parse it
but a lot of them didn't.  This commit avoids the segfault by substituting
an empty string when no argument is given.  It also updates a few of the
action implementations to correspond.

Reported-by: Reid Price <reid at nicira.com>
Bug #4462.
Coverity #10712.

commit 338bd6a0fe317e6a320aca67a1dc2d090ef77de9
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=338bd6a0fe317e6a320aca67a1dc2d090ef77de9
Author: Ben Pfaff <blp at nicira.com>
nicira-ext: Fix comment.
Multipath actions only support registers as destinations, but this was
defined by reference in nicira-ext.h and the referenced text changed.


Summary of changes:
 include/openflow/nicira-ext.h |    5 ++-
 lib/multipath.c               |   26 ++++++++++++++++++-----
 lib/ofp-parse.c               |   14 ++++++++----
 tests/multipath.at            |   45 +++++++++++++++++++++++++++++++++++++---
 utilities/ovs-ofctl.c         |   41 ++++++++++++++++++++++++++++++-------
 5 files changed, 106 insertions(+), 25 deletions(-)

Open vSwitch

More information about the git mailing list