[ovs-git] Open vSwitch: ovsdb: Warn when result of ovsdb_txn_commit() is ignored and fix caller. (master)

dev at openvswitch.org dev at openvswitch.org
Wed Feb 23 19:11:07 UTC 2011

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  5f8e32136eacbc91b7422b17d8208a64cfb3b8b9 (commit)
       via  828cd4c7cd666b93f72d57e5932b5becf0809619 (commit)
       via  811da49f926464b9cc3aab7e6ed5e1dfd223d4b2 (commit)
       via  400eb935f2d781494b13569863ce9637d18ddb1a (commit)
       via  85683160294584a636ef07d5039c77acf616d82d (commit)
       via  cea0c3936779b1b7e1001165bcc7763e1a60355c (commit)
       via  f2cc621bacf07a48e65e163e3420c7594fd65cfd (commit)
       via  84ba64b96410c8b87611ec000b9e2d29dfeb06d9 (commit)
      from  770f1f66bb9dc4e784e6c2c5351089c62b9a5919 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5f8e32136eacbc91b7422b17d8208a64cfb3b8b9
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=5f8e32136eacbc91b7422b17d8208a64cfb3b8b9
Author: Justin Pettit <jpettit at nicira.com>
ovsdb: Warn when result of ovsdb_txn_commit() is ignored and fix caller.
ovsdb_txn_commit() may return a ovsdb_error structure, which should be
freed by the caller.  The only remaining caller that discards the result
is in ovsdb_file_open__(), which this fixes.

Suggested-by: Ben Pfaff <blp at nicira.com>

commit 828cd4c7cd666b93f72d57e5932b5becf0809619
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=828cd4c7cd666b93f72d57e5932b5becf0809619
Author: Justin Pettit <jpettit at nicira.com>
ovsdb-idl: Remove deadcode related to "reply" in ovsdb_idl_run().
Coverity #10705

commit 811da49f926464b9cc3aab7e6ed5e1dfd223d4b2
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=811da49f926464b9cc3aab7e6ed5e1dfd223d4b2
Author: Justin Pettit <jpettit at nicira.com>
nx-match: Don't fall through case when handling dest mcast mac addresses.
When an NXM wildcard entry that includes a multicast address is parsed,
it would fall through to the next case statement, which would also set
an inappropriate source mac address match.

Coverity #10717

commit 400eb935f2d781494b13569863ce9637d18ddb1a
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=400eb935f2d781494b13569863ce9637d18ddb1a
Author: Justin Pettit <jpettit at nicira.com>
ovsdb-tool: Close "log" in do_show_log().
Coverity #10726

commit 85683160294584a636ef07d5039c77acf616d82d
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=85683160294584a636ef07d5039c77acf616d82d
Author: Justin Pettit <jpettit at nicira.com>
test-ovsdb: Don't leak return value from ovsdb_txn_commit().
Coverity #10727

commit cea0c3936779b1b7e1001165bcc7763e1a60355c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=cea0c3936779b1b7e1001165bcc7763e1a60355c
Author: Justin Pettit <jpettit at nicira.com>
ovs-vsctl: Free "columns" in cmd_find().
Coverity #10730

commit f2cc621bacf07a48e65e163e3420c7594fd65cfd
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=f2cc621bacf07a48e65e163e3420c7594fd65cfd
Author: Justin Pettit <jpettit at nicira.com>
netdev-linux: Zero-out "sin" in netdev_linux_arp_lookup().
Coverity complains that we're copying the unitialized "sin_zero" member
from "sin" into "r".  I don't think this is an actual problem, but
there's no harm in zeroing out the structure, either.

Coverity #10916

commit 84ba64b96410c8b87611ec000b9e2d29dfeb06d9
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=84ba64b96410c8b87611ec000b9e2d29dfeb06d9
Author: Justin Pettit <jpettit at nicira.com>
table: Free "error" in cell_to_text().
Coverity #10722


Summary of changes:
 lib/netdev-linux.c    |    1 +
 lib/nx-match.c        |    2 ++
 lib/ovsdb-idl.c       |    6 +-----
 lib/table.c           |    2 ++
 ovsdb/file.c          |    2 +-
 ovsdb/ovsdb-tool.c    |    1 +
 ovsdb/transaction.h   |    3 ++-
 tests/test-ovsdb.c    |    2 +-
 utilities/ovs-vsctl.c |    1 +
 9 files changed, 12 insertions(+), 8 deletions(-)

Open vSwitch

More information about the git mailing list