[ovs-git] Open vSwitch: ovsdb: Explicitly ignore sscanf() return value in is_valid_version(). (master)

dev at openvswitch.org dev at openvswitch.org
Wed Feb 23 23:19:19 UTC 2011

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  1883ed0f727bd10f0b8b6b80832029c349138595 (commit)
       via  bca51200523113950f223666a5d07fb993e319f7 (commit)
       via  c7884b9fc794d067672e3195bcb784bd9fe13380 (commit)
       via  1611cf3f5abbff87b4443d2807b369fdd327eb49 (commit)
       via  fbca1e20e84bc34537f0a3db073195f6783fb373 (commit)
       via  4a433a0fc58cd29612d349bf0fc4da73d97d0aed (commit)
       via  1cec7ca1a2d9341b6c69d9b6c19792b341db3f6e (commit)
       via  0f0b102dcf5c067259788e54a0a5352851ed1565 (commit)
       via  82c2b79de650665f18d847c1771d28430486225e (commit)
       via  93e039fb5e7ae77a556e1d144ca069a86555598b (commit)
       via  c55acc2eed76ae17667fa5f65f5f3c347b796926 (commit)
       via  fe81a2987abeda195f6535cab973b1c753cca4b3 (commit)
      from  0b420b100ac540d45a45e45d40e6581b0c5f7eb5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1883ed0f727bd10f0b8b6b80832029c349138595
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=1883ed0f727bd10f0b8b6b80832029c349138595
Author: Ben Pfaff <blp at nicira.com>
ovsdb: Explicitly ignore sscanf() return value in is_valid_version().
The return value isn't interesting here: it will always be 0.

Coverity #10698.

commit bca51200523113950f223666a5d07fb993e319f7
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=bca51200523113950f223666a5d07fb993e319f7
Author: Ben Pfaff <blp at nicira.com>
test-ovsdb: Check uuid_from_string() return value.
Coverity #10699.

commit c7884b9fc794d067672e3195bcb784bd9fe13380
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c7884b9fc794d067672e3195bcb784bd9fe13380
Author: Ben Pfaff <blp at nicira.com>
dhcp-client: Remove useless call to timeout() from send_reliably().
timeout() has no side effects so calling it without looking at the return
value is pointless.

Coverity #10700.

commit 1611cf3f5abbff87b4443d2807b369fdd327eb49
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=1611cf3f5abbff87b4443d2807b369fdd327eb49
Author: Ben Pfaff <blp at nicira.com>
ovs-vsctl: Clarify that uuid_from_string() shouldn't fail in post_create().
Coverity #10701.

commit fbca1e20e84bc34537f0a3db073195f6783fb373
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=fbca1e20e84bc34537f0a3db073195f6783fb373
Author: Ben Pfaff <blp at nicira.com>
ovs-kill: Remove.
This utility isn't used anywhere (except INSTALL.Linux), so remove it.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Coverity #10708.

commit 4a433a0fc58cd29612d349bf0fc4da73d97d0aed
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=4a433a0fc58cd29612d349bf0fc4da73d97d0aed
Author: Ben Pfaff <blp at nicira.com>
ovs-vsctl: Simplify parse_column_key_value().
Coverity pointed out some inconsistencies on tests for whether columnp and
keyp were nonnull.  These tests were, at best, confusing, but in fact every
caller always passed nonnull for both parameters, so this commit drops all
of those tests.

Coverity #10715, 10710.

commit 1cec7ca1a2d9341b6c69d9b6c19792b341db3f6e
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=1cec7ca1a2d9341b6c69d9b6c19792b341db3f6e
Author: Ben Pfaff <blp at nicira.com>
ovs-brcompatd: Simplify code in brc_recv_update().
This code was baffling and it confused Coverity, too.

Coverity #11070.

commit 0f0b102dcf5c067259788e54a0a5352851ed1565
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=0f0b102dcf5c067259788e54a0a5352851ed1565
Author: Ben Pfaff <blp at nicira.com>
ovsdb-idl: JSONRPC_REPLY message always has nonnull 'id'.
A JSONRPC_REPLY message always have a nonnull 'id' member, as ensured by
jsonrpc_msg_is_valid().  Checking for NULL here confused Coverity into
believing that the call to ovsdb_idl_txn_process_reply() just below could
cause a null pointer dereference, since ovsdb_idl_txn_process_reply() uses
the 'id' member without checking it for null.

Coverity #10713.

commit 82c2b79de650665f18d847c1771d28430486225e
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=82c2b79de650665f18d847c1771d28430486225e
Author: Ben Pfaff <blp at nicira.com>
rconn: Clarify rconn_run_wait().
At first glance the vconn_wait() call looks risky because this function
checked whether rc->vconn is nonnull at the top.  In fact it's OK because
rc->state will be S_ACTIVE or S_IDLE only if rc->vconn is nonnull, but
there's no harm in putting that check inside the block that only runs if
rc->vconn is nonnull.

Coverity #10714.

commit 93e039fb5e7ae77a556e1d144ca069a86555598b
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=93e039fb5e7ae77a556e1d144ca069a86555598b
Author: Ben Pfaff <blp at nicira.com>
leak-checker: Avoid printing freed pointer.
I think that this will work OK, and it should avoid complaints from static
checkers about using a freed pointer.

Coverity #11069.

commit c55acc2eed76ae17667fa5f65f5f3c347b796926
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c55acc2eed76ae17667fa5f65f5f3c347b796926
Author: Ben Pfaff <blp at nicira.com>
stream: Make stream_report_content() tolerate negative size.
A negative size probably means that a system call failed.  The caller could
set that to 0 but we might as well just tolerate it in
stream_report_content() by making the parameter type signed.

Coverity #10718.

commit fe81a2987abeda195f6535cab973b1c753cca4b3
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=fe81a2987abeda195f6535cab973b1c753cca4b3
Author: Ben Pfaff <blp at nicira.com>
process: Avoid late failure if /dev/null cannot be opened.
It is (very slightly) risky to open /dev/null every time that we need it,
because open can fail.  So this commit opens /dev/null in advance instead.

Coverity #10719.


Summary of changes:
 INSTALL.Linux                      |    2 +-
 debian/openvswitch-switch.install  |    1 -
 debian/openvswitch-switch.manpages |    1 -
 lib/dhcp-client.c                  |    1 -
 lib/leak-checker.c                 |    3 +-
 lib/ovsdb-idl.c                    |    5 +-
 lib/process.c                      |   24 +++-
 lib/rconn.c                        |    9 +-
 lib/stream.c                       |    4 +-
 lib/stream.h                       |    5 +-
 ovsdb/ovsdb.c                      |    2 +-
 tests/test-ovsdb.c                 |    6 +-
 utilities/.gitignore               |    2 -
 utilities/automake.mk              |    7 --
 utilities/ovs-kill.8.in            |   60 ----------
 utilities/ovs-kill.c               |  208 ------------------------------------
 utilities/ovs-vsctl.c              |   72 +++++--------
 vswitchd/ovs-brcompatd.c           |   45 ++++++---
 xenserver/openvswitch-xen.spec     |    2 -
 19 files changed, 95 insertions(+), 364 deletions(-)
 delete mode 100644 utilities/ovs-kill.8.in
 delete mode 100644 utilities/ovs-kill.c

Open vSwitch

More information about the git mailing list