[ovs-git] Open vSwitch: For SNAT, don't store the pre-fragment L2 header before actions are applied. (for-nox/0.4)

dev at openvswitch.org dev at openvswitch.org
Mon Jan 24 07:06:13 UTC 2011

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, for-nox/0.4 has been updated
       via  b4cd6fb07e0751832a22759e27c6ba63e3538c8b (commit)
      from  dfc7aa676ab44db7a49284a80798c7be5369db85 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b4cd6fb07e0751832a22759e27c6ba63e3538c8b
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=b4cd6fb07e0751832a22759e27c6ba63e3538c8b
Author: Justin Pettit <jpettit at nicira.com>
For SNAT, don't store the pre-fragment L2 header before actions are applied.
The IP fragment code doesn't always write the L2 header when generating
new fragments.  This problem was fixed in an earlier commit.
Unfortunately, we stored the pre-fragment L2 header when the packet
first arrived--before other packet modifications were applied.  This
meant that the results of any OpenFlow L2 modification actions were lost.
This patch pushes the storage of the L2 header until right before the
packet is transmitted (and possibly refragmented).

Thanks to Dan for catching this behavior.


Summary of changes:
 datapath/datapath.c    |   11 +++++++----
 datapath/nx_act_snat.c |    6 ++++--
 datapath/nx_act_snat.h |    1 +
 3 files changed, 12 insertions(+), 6 deletions(-)

Open vSwitch

More information about the git mailing list