[ovs-git] Open vSwitch: datapath: s/ODPAT_/ODP_ACTION_ATTR_/ to fit new naming scheme. (netlink)

dev at openvswitch.org dev at openvswitch.org
Wed Jan 26 21:17:11 UTC 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, netlink has been updated
  discards  acae1b860a533f207f86103a225552aafc573b2c (commit)
  discards  1b136d5f03a68ac7118c50d8268972277f660c5b (commit)
  discards  5fb6a8df6b7f350fde942f61d276287bf62a939b (commit)
  discards  39b809396a8a3064e1fcb6fb05de096aec5104ff (commit)
  discards  d60f8a35cebac40fbc3ed0b63abf5ea61cad1d50 (commit)
  discards  73ff206847af9d80f6683dff24012656de63ba28 (commit)
  discards  bdba99563aa07b72374052cba052bf725ac7db54 (commit)
  discards  2ed0ea2d65eb34a52b12e2c487ba53ada9baa30e (commit)
  discards  ca4df57ccb25802a9f67064d41234d1009db3d9a (commit)
  discards  b2cee5696315b095e7939c1544f00e02e36e4feb (commit)
  discards  b01ce553c5f2814e8f8078142e7c684b1e89767a (commit)
  discards  43ae32abeed7aa71a3f78046cc4c79b21994b7d8 (commit)
  discards  88c7aff51dc39122d6855b8736b5bcdd70dd1d84 (commit)
  discards  d774546ab969591d3e05b8975ce505b1ee8b9b9a (commit)
  discards  c10647bbde85205cdb97f8e821b6357f3ba34116 (commit)
  discards  fb35c923ba83c13b0faefc958a4856d1bc749559 (commit)
  discards  069de0769af060c8e476b5fdc94b6bceac8f0e5d (commit)
  discards  a2c7801c40b900243c637a05e0e31c14bf225543 (commit)
  discards  bf77493b7613fdcbd96469ea00681c8e0986bfc0 (commit)
  discards  efa9ab808602050c9e7ca9fbfada4395425590b4 (commit)
  discards  55967e976ab821bcd1ab73c1824eaa96f9cddf81 (commit)
  discards  f630ad6cdf21d003af7ebf481a7f4b5ad8d19070 (commit)
  discards  4a8f10f380db2771cbcbd18680c58f10e71f0b49 (commit)
  discards  969f251c35f3ce5258b48308521cee1fcdcdf6f1 (commit)
  discards  062e690bd08fe3020297fb326683c332c029b277 (commit)
  discards  2395940643ad0242c0b4f7b2acde3491f3accc51 (commit)
  discards  7ad368e45143f97350bb13015cd26e55e9410ca7 (commit)
  discards  e9bb108aa3f96277900fd3d6d7525bb54228a203 (commit)
  discards  6a90c46b4493c595b1dce8de1d001fcd0f2228f0 (commit)
  discards  e4df8357393a74f3c414812ad5922773a0495c7e (commit)
  discards  d5aeb25fcfbb4c58e6cbe7efbd5b0ed2ae4479a6 (commit)
  discards  e5cb5d01992f70d035127d66998e4238c03ede34 (commit)
  discards  1ffdb3ac26fab349599dff0b68685492410a8faf (commit)
  discards  ffd16aaed01b12e9db2bf11f9aec70dbeba6eed4 (commit)
  discards  ce71425e98a74541f8051250a3b68cff903a4f2d (commit)
  discards  23385e1b48a11cc75ca4d8f187a1558f5cd29907 (commit)
  discards  8dbbc841d9b3f52eae30e404a9b2582b1fe5ba4e (commit)
       via  ae5f820735c90197cc90d23ddf27a4aae449f41b (commit)
       via  1e7313c54d7aaf24658727a195c84fc65c5d556c (commit)
       via  9e1580dd58aa35e78e89785e9cfceb76d8cda26a (commit)
       via  31a8bb9397adc989b6872819e4dc97324f39f339 (commit)
       via  614800d8db7d6b89c73d1c666fe80a9c5f8fa793 (commit)
       via  7b1ed5c1d7fce822df815e3756f74fb0b9bbb894 (commit)
       via  5861542638e398af5b11a535b7aa99084ad02222 (commit)
       via  a16917d2cee4214148f6e76aa77557ab6fd98f39 (commit)
       via  45d6572ad8a1e9d9b07308b6a3f8555cc7726964 (commit)
       via  b423813ebe578a6008e09f899d52bb4b29674161 (commit)
       via  6c8f010977835ccc4bb2a38693afe8fb47549030 (commit)
       via  0042d3e786fa706ddc2cbe61fdbb49224b657faf (commit)
       via  6c57c32eda96f02ccefc933614219e4b1ab1fe50 (commit)
       via  052ecbd1ec4e705fae65fc85c6ec8d1b966cd49a (commit)
       via  c1ae3d764c1a88864f91546c0379964dbd86a9a5 (commit)
       via  5748e0fa85b383ada5f021b8fbd37fe3680990c2 (commit)
       via  68eee773741bb42a97af73b1a057ed67697a1b8e (commit)
       via  da657c917faff08e2d7cf3ac225723ac2acd70fb (commit)
       via  f30e06427cad639549642811a2997c7a62183ade (commit)
       via  eac98c61656bcae0fda7395e392f40d87f776a24 (commit)
       via  8a5193612a8534ae995830b32c2653e2cb6adc36 (commit)
       via  0f9b4548543ff4440e73fcb9720313e324b5a456 (commit)
       via  8966d4f149d83875b916d2e48b3ed354f3c3c86d (commit)
       via  8ef5df80df3ba337a0d965963c89f86545a13eef (commit)
       via  806616ca247d9130cd219767bb072a788881db74 (commit)
       via  dca5c7963278cc13b12eba9dda1482d7616532ac (commit)
       via  25fa3a53d756731a2536dfa90bb8d28c048d05a2 (commit)
       via  cf795d038d94f54d8a632d3f4531ac2f6f7f6e88 (commit)
       via  b3965e65753d1fbcc26e4478e791d0a2044bc396 (commit)
       via  494e35e0694aac06c6fe0284c8fb1f3708b11fd6 (commit)
       via  78f3b4dc6f48cb0974324bd6fd7eef338a09d90d (commit)
       via  c127cd64df26930e94bb1afef68c17bf98883c73 (commit)
       via  c1174662b2b31ab424f296e02295673e65f1cbb6 (commit)
       via  1d9f644fac513b17de7119b7f691cdb46a23dfda (commit)
       via  aff748f1a605ae3eb331749c25e701ad30238dd4 (commit)
       via  aa30d6d458124d8e36ac754f333baa8bb2061c44 (commit)
       via  f256c08e30e33f315f6f7182fdb9c9dd75a5e156 (commit)
      from  acae1b860a533f207f86103a225552aafc573b2c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ae5f820735c90197cc90d23ddf27a4aae449f41b
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=ae5f820735c90197cc90d23ddf27a4aae449f41b
Author: Ben Pfaff <blp at nicira.com>
		
datapath: s/ODPAT_/ODP_ACTION_ATTR_/ to fit new naming scheme.
		
Jesse suggested this naming scheme, so I'm adjusting existing names to
fit it.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 1e7313c54d7aaf24658727a195c84fc65c5d556c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=1e7313c54d7aaf24658727a195c84fc65c5d556c
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Expand skbuff head if necessary to include actions.
		
NLMSG_GOODSIZE limits the size of a single Netlink message that can be
output as part of a Netlink dump.  Sometimes there are lots of actions in
a flow, though, so that we need more than NLMSG_GOODSIZE bytes just for
the actions.  So in cases where the actions won't all fit within the
preallocated header area, expand the header.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


commit 9e1580dd58aa35e78e89785e9cfceb76d8cda26a
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=9e1580dd58aa35e78e89785e9cfceb76d8cda26a
Author: Ben Pfaff <blp at nicira.com>
		
dpif: Remove dpif_get_all_names().
		
None of the remaining dpif implementations have more than one name per
dpif, so there's no need for this function anymore.

Suggested-by: Jesse Gross <jesse at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


commit 31a8bb9397adc989b6872819e4dc97324f39f339
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=31a8bb9397adc989b6872819e4dc97324f39f339
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Change dp_idx to dp_ifindex, the ifindex of the local port.
		
I can't see any real value in maintaining a dp_idx separate from the
ifindex of the local port.  With the current implementation it also
artificially limits the number of datapaths.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 614800d8db7d6b89c73d1c666fe80a9c5f8fa793
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=614800d8db7d6b89c73d1c666fe80a9c5f8fa793
Author: Ben Pfaff <blp at nicira.com>
		
xenserver: Use "ovs-dpctl dump-dps" instead of parsing "ovs-dpctl show".
		
Might as well use the dump-dps command as intended.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


commit 7b1ed5c1d7fce822df815e3756f74fb0b9bbb894
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=7b1ed5c1d7fce822df815e3756f74fb0b9bbb894
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Backport more Netlink functions.
		
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


commit 5861542638e398af5b11a535b7aa99084ad02222
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=5861542638e398af5b11a535b7aa99084ad02222
Author: Ben Pfaff <blp at nicira.com>
		
dpif-linux: Replace 'minor' by 'dp_idx'.
		
The dp_idx used to be the character device minor number, but there's no
character device anymore, so rename for clarity.

Reviewed by Justin Pettit.


commit a16917d2cee4214148f6e76aa77557ab6fd98f39
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a16917d2cee4214148f6e76aa77557ab6fd98f39
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Add multicast group to flows.
		
To be squashed into previous commit.


commit 45d6572ad8a1e9d9b07308b6a3f8555cc7726964
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=45d6572ad8a1e9d9b07308b6a3f8555cc7726964
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Convert ODP_FLOW_* commands to use AF_NETLINK socket layer.
		
This completes the transition to the Generic Netlink interface, and
so this commit restores support for Linux 2.6.18 and later.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit b423813ebe578a6008e09f899d52bb4b29674161
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=b423813ebe578a6008e09f899d52bb4b29674161
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Add multicast group for vports.
		
To be squashed in with previous commit.


commit 6c8f010977835ccc4bb2a38693afe8fb47549030
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=6c8f010977835ccc4bb2a38693afe8fb47549030
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Convert ODP_VPORT_* to use AF_NETLINK socket layer.
		
This commit calls genl_lock() and thus doesn't support Linux before
2.6.35, which wasn't exported before that version.  That problem will
be fixed once the whole userspace interface transitions to Generic
Netlink a few commits from now.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 0042d3e786fa706ddc2cbe61fdbb49224b657faf
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=0042d3e786fa706ddc2cbe61fdbb49224b657faf
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Add multicast group to dp.
		
To be squashed in with previous commit.


commit 6c57c32eda96f02ccefc933614219e4b1ab1fe50
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=6c57c32eda96f02ccefc933614219e4b1ab1fe50
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Convert ODP_DP_* commands to use AF_NETLINK socket layer.
		
This commit calls genl_lock() and thus doesn't support Linux before
2.6.35, which wasn't exported before that version.  That problem will
be fixed once the whole userspace interface transitions to Generic
Netlink a few commits from now.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 052ecbd1ec4e705fae65fc85c6ec8d1b966cd49a
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=052ecbd1ec4e705fae65fc85c6ec8d1b966cd49a
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Convert upcalls and ODP_EXECUTE to use AF_NETLINK socket layer.
		
This commit calls genl_lock() and thus doesn't support Linux before
2.6.35, which wasn't exported before that version.  That problem will
be fixed once the whole userspace interface transitions to Generic
Netlink a few commits from now.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit c1ae3d764c1a88864f91546c0379964dbd86a9a5
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c1ae3d764c1a88864f91546c0379964dbd86a9a5
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Adopt Generic Netlink-compatible locking.
		
The kernel Generic Netlink layer always holds a mutex (genl_lock) when it
invokes callbacks, so that means that there is no point in having
per-datapath mutexes or a separate vport lock.  This commit removes them.

This commit breaks support for Linux before 2.6.35 because it calls
genl_lock(), which wasn't exported before that version.  That problem will
be fixed once the whole userspace interface transitions to Generic
Netlink a few commits from now.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 5748e0fa85b383ada5f021b8fbd37fe3680990c2
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=5748e0fa85b383ada5f021b8fbd37fe3680990c2
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Eliminate vport_mutex by protecting vport table with RCU.
		
The vport_mutex really only protects the vport dev_table, which isn't very
much.  By getting rid of it we take one step toward simplifying the vswitch
locking, which will necessarily have to be based mainly around the Generic
Netlink genl_mutex once we switch to Generic Netlink.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 68eee773741bb42a97af73b1a057ed67697a1b8e
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=68eee773741bb42a97af73b1a057ed67697a1b8e
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Backport genl_register_family_with_ops().
		
Besides the user introduced in this commit, the new Netlink-based datapath
communication code will use this function.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>
Reported-by: Justin Pettit <jpettit at nicira.com>


commit da657c917faff08e2d7cf3ac225723ac2acd70fb
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=da657c917faff08e2d7cf3ac225723ac2acd70fb
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Extend compatibility code for genl_register_mc_group().
		
The existing compatibility code for genl_register_mc_group() always returns
the same value because the only caller (in brcompat_mod) only needs a
single multicast group.  However, when the datapath is converted over to
using Netlink in an upcoming commit, openvswitch_mod will start needing a
number of multicast groups, so this commit adds this ability.

The multicast group ranges differ for brcompat_mod and openvswitch_mod so
that they don't interfere with one another.  (This would waste time in
ovs-brcompatd and ovs-vswitchd, although it would not be fatal.)

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


commit f30e06427cad639549642811a2997c7a62183ade
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=f30e06427cad639549642811a2997c7a62183ade
Author: Ben Pfaff <blp at nicira.com>
		
Eliminate ODPL_* from userspace-facing interface.
		
Reviewed by Justin Pettit.


commit eac98c61656bcae0fda7395e392f40d87f776a24
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=eac98c61656bcae0fda7395e392f40d87f776a24
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Get rid of ODPP_NONE.
		
This definition wasn't actually useful for the kernel--the only place that
it was used it didn't really have to be, so this commit removes it from
datapath-protocol.h.  It is still marginally useful in userspace, at least
as a value that converts to and from OpenFlow port number OFPP_NONE, so
move it to odp-util.c.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


commit 8a5193612a8534ae995830b32c2653e2cb6adc36
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=8a5193612a8534ae995830b32c2653e2cb6adc36
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Convert ODP_EXECUTE to use Netlink framing.
		
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 0f9b4548543ff4440e73fcb9720313e324b5a456
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=0f9b4548543ff4440e73fcb9720313e324b5a456
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Remove non-standard nla_put_be{16,32,64} functions.
		
These aren't part of any version of Linux, so delete them now that the code
does not use them.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Suggested-by: Jesse Gross <jesse at nicira.com>


commit 8966d4f149d83875b916d2e48b3ed354f3c3c86d
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=8966d4f149d83875b916d2e48b3ed354f3c3c86d
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Convert datapath operations to use Netlink framing.
		
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 8ef5df80df3ba337a0d965963c89f86545a13eef
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=8ef5df80df3ba337a0d965963c89f86545a13eef
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Convert ODP_FLOW_* and ODP_EXECUTE to put dp_idx into message.
		
When the datapath moves to the Netlink protocol it won't have a minor
number to use, so we have to put the dp_idx in the message.

This also changes the kernel implementation of ODP_FLOW_FLUSH to do the
datapath locking inside flush_flows() instead of inside openvswitch_ioctl()
but doesn't change that command's userspace interface, which still passes
a datapath number as the ioctl argument.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 806616ca247d9130cd219767bb072a788881db74
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=806616ca247d9130cd219767bb072a788881db74
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Eliminate 'flags' member from odp_flow.
		
Nothing was productively using the 'flags' member of odp_flow, so this
commit removes it.

ODPFF_ZERO_TCP_FLAGS isn't used at all (as of the previous commit).

ODPFF_EOF has been replaced by a special case of the 'key_len' member.
This will go away, too, once AF_NETLINK starts being used.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


commit dca5c7963278cc13b12eba9dda1482d7616532ac
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=dca5c7963278cc13b12eba9dda1482d7616532ac
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Avoid using ODPFF_ZERO_TCP_FLAGS.
		
I'm planning to remove this flag, since it is a bit of a wart, so this
commit deletes its only actual user.

Reviewed by Ethan Jackson <ethan at nicira.com>.


commit 25fa3a53d756731a2536dfa90bb8d28c048d05a2
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=25fa3a53d756731a2536dfa90bb8d28c048d05a2
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Generalize facet_put__() so that it is more useful.
		
This immediately makes it useful in facet_revalidate().  An upcoming
patch will add one more user.

This commit should not change any externally visible behavior.  It
is a pure code refactoring.

Reviewed by Ethan Jackson <ethan at nicira.com>.


commit cf795d038d94f54d8a632d3f4531ac2f6f7f6e88
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=cf795d038d94f54d8a632d3f4531ac2f6f7f6e88
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Fix test for installability change when revalidating.
		
ctx.may_set_up_flow will become the new facet->may_install, so it's that
value that we should check instead of the current facet->may_install when
deciding whether to update the datapath flow.

Reviewed by Ethan Jackson <ethan at nicira.com>.


commit b3965e65753d1fbcc26e4478e791d0a2044bc396
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=b3965e65753d1fbcc26e4478e791d0a2044bc396
Author: Ben Pfaff <blp at nicira.com>
		
dpif: Eliminate ODPPF_* constants from client-visible interface.
		
Following this commit, the ODPPF_* constants are only used in
Linux-specific parts of OVS userspace code.  This allows the actual Linux
datapath interface to evolve more freely.

Reviewed by Justin Pettit.


commit 494e35e0694aac06c6fe0284c8fb1f3708b11fd6
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=494e35e0694aac06c6fe0284c8fb1f3708b11fd6
Author: Ben Pfaff <blp at nicira.com>
		
dpif: Eliminate "struct odp_flow_stats" from client-visible interface.
		
Following this commit, "struct odp_flow_stats" is only used in
Linux-specific parts of OVS userspace code.  This allows the actual Linux
datapath interface to evolve more freely.

Reviewed by Justin Pettit.


commit 78f3b4dc6f48cb0974324bd6fd7eef338a09d90d
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=78f3b4dc6f48cb0974324bd6fd7eef338a09d90d
Author: Ben Pfaff <blp at nicira.com>
		
dpif: Eliminate "struct odp_flow" from client-visible interface.
		
Following this commit, "struct odp_flow" and related data structures are
only used in Linux-specific parts of OVS userspace code.  This allows the
actual Linux datapath interface to evolve more freely.

Reviewed by Justin Pettit.


commit c127cd64df26930e94bb1afef68c17bf98883c73
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c127cd64df26930e94bb1afef68c17bf98883c73
Author: Ben Pfaff <blp at nicira.com>
		
ovs-dpctl: Use datapath enumeration functions instead of guessing names.
		
I'm planning to get rid of userspace knowledge of ODP_MAX and this change
gets rid of one user of it.

Reviewed by Justin Pettit.


commit c1174662b2b31ab424f296e02295673e65f1cbb6
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c1174662b2b31ab424f296e02295673e65f1cbb6
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Change ODP_FLOW_GET to retrieve only a single flow at a time.
		
This brings the code closer to what the Netlink interface will need to
implement.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


commit 1d9f644fac513b17de7119b7f691cdb46a23dfda
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=1d9f644fac513b17de7119b7f691cdb46a23dfda
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Drop port information from odp_stats.
		
As with n_flows, n_ports was used regularly by userspace to determine how
much memory to allocate when listing ports, but it is no longer needed for
that.  max_ports, on the other hand, is necessary but it is also a fixed
value for the kernel datapath right now and if we expand it we can also
come up with a way to report the expanded value.

The remaining members of odp_stats are actually real statistics that I
intend to keep.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


commit aff748f1a605ae3eb331749c25e701ad30238dd4
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=aff748f1a605ae3eb331749c25e701ad30238dd4
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Drop queue information from odp_stats.
		
This queue information will be available through the kernel socket layer
once we move over to Netlink socket as transports, so we might as well get
rid of the redundancy.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


commit aa30d6d458124d8e36ac754f333baa8bb2061c44
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=aa30d6d458124d8e36ac754f333baa8bb2061c44
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Drop flow information from odp_stats.
		
Userspace used to use the n_flows information here to decide how much
memory needed to be allocated to list flows, but that isn't necessary any
longer now that listing flows uses an iterator abstraction.  The
cur_capacity and max_capacity members are just curiosities and don't
provide much information; if the implementation ever changes away from
the current hash table implementation then they could become meaningless
anyhow.

But more than anything, these aren't really the kind of statistics that
networking people usually care about.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


commit f256c08e30e33f315f6f7182fdb9c9dd75a5e156
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=f256c08e30e33f315f6f7182fdb9c9dd75a5e156
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Change userspace vport interface to use Netlink attributes.
		
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other.  To do this in full generality, it must be possible to add new
features to the kernel vport layer without changing userspace software.
The customary way to do this in the Linux networking stack is to use
Netlink and in particular Netlink attributes.  This commit adopts that
model for the vport layer.  It does not yet actually start using the
Netlink socket layer, which will come later.

Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 datapath/datapath.c           |   40 +++++++++++++++-------------------------
 datapath/datapath.h           |   25 +++++++------------------
 datapath/vport-internal_dev.c |    1 +
 datapath/vport.c              |   18 +++++++-----------
 datapath/vport.h              |    3 ++-
 lib/dpif-linux.c              |    6 +++---
 6 files changed, 35 insertions(+), 58 deletions(-)


hooks/post-receive
-- 
Open vSwitch




More information about the git mailing list